Progress bar fixes (librenms#18616)

Fix undefined array key error
Fix right background color not being applied (and update default)

Author: murrant

LibreNMS/Util/Color.php

@@ -58,30 +58,30 @@ public static function percentage($percentage, $component_perc_warn = null): arr
         if ($percentage > 75) {
             return [
                 'left' => 'bf5d5b',
-                'right' => 'd39392',
+                'right' => 'eaeaea',
                 'middle' => 'c97e7d',
             ];
         }
 
         if ($percentage > 50) {
             return [
                 'left' => 'bf875b',
-                'right' => 'd3ae92',
+                'right' => 'eaeaea',
                 'middle' => 'cca07e',
             ];
         }
 
         if ($percentage > 25) {
             return [
                 'left' => '5b93bf',
-                'right' => '92b7d3',
+                'right' => 'eaeaea',
                 'middle' => '7da8c9',
             ];
         }
 
         return [
             'left' => '9abf5b',
-            'right' => 'bbd392',
+            'right' => 'eaeaea',
             'middle' => 'afcc7c',
         ];
     }

LibreNMS/Util/Html.php

@@ -145,14 +145,14 @@ public static function percentageBar($width, $height, $percent, $left_text = '',
             $colors = Color::percentage($percent, $warn ?: null);
         }
         $default = Color::percentage(0);
-        $left_text_color = $colors['left_text'] ? '#' . $colors['left_text'] : 'inherit';
-        $right_text_color = $colors['right_text'] ? '#' . $colors['right_text'] : 'inherit';
+        $left_text_color = empty($colors['left_text']) ? 'inherit' : '#' . $colors['left_text'];
+        $right_text_color = empty($colors['right_text']) ? 'inherit' : '#' . $colors['right_text'];
         $left_color = $colors['left'] ?? $default['left'];
         $right_color = $colors['right'] ?? $default['right'];
 
         $output = [];
         $output[] = '<div style="width:' . $width . 'px">';
-        $output[] = '<div class="progress" style="background-color:#eaeaea; height:' . $height . 'px; margin-bottom: 4px;">';
+        $output[] = '<div class="progress" style="background-color:#' . $right_color . '; height:' . $height . 'px; margin-bottom: 4px;">';
 
         $output[] = '<div class="progress-bar" role="progressbar" aria-valuenow="' . $percent . '" aria-valuemin="0" aria-valuemax="100" style="width:' . $percent . '%; background-color: #' . $left_color . '; height:' . $height . 'px;"></div>';