Fix mtu status changed event log 1 -> 1 (librenms#18683)

* Fix mtu status changed event log 1 -> 1
Add attribute name to eventlog
Only update/log specific attributes

* Use common log message format

Author: murrant

LibreNMS/Modules/Core.php

@@ -29,6 +29,7 @@
 use App\Facades\LibrenmsConfig;
 use App\Models\Device;
 use App\Models\Eventlog;
+use App\Observers\DeviceObserver;
 use Illuminate\Support\Facades\Cache;
 use Illuminate\Support\Str;
 use LibreNMS\Enum\Severity;
@@ -70,9 +71,12 @@ public function discover(OS $os): void
             'sysDescr' => $snmpdata['.1.3.6.1.2.1.1.1.0'] ?? null,
         ]);
 
-        foreach ($device->getDirty() as $attribute => $value) {
-            Eventlog::log($value . ' -> ' . $device->$attribute, $device, 'system', Severity::Notice);
-            $os->getDeviceArray()[$attribute] = $value; // update device array
+        foreach (['sysObjectID', 'sysName', 'sysDescr'] as $attribute) {
+            if ($device->isDirty($attribute)) {
+                $message = DeviceObserver::attributeChangedMessage($attribute, $device->$attribute, $device->getOriginal($attribute));
+                Eventlog::log($message, $device, 'system', Severity::Notice);
+                $os->getDeviceArray()[$attribute] = $device->$attribute; // update device array
+            }
         }
 
         // detect OS

app/Models/Device.php

@@ -99,6 +99,7 @@ protected function casts(): array
             'last_polled' => 'datetime',
             'last_ping' => 'datetime',
             'status' => 'boolean',
+            'mtu_status' => 'boolean',
             'ignore' => 'boolean',
             'ignore_status' => 'boolean',
             'disabled' => 'boolean',

app/Observers/DeviceObserver.php

@@ -237,7 +237,7 @@ public function pivotAttached(Device $device, $relationName, $pivotIds, $pivotId
         }
     }
 
-    public static function attributeChangedMessage($attribute, $value, $previous)
+    public static function attributeChangedMessage($attribute, $value, $previous): string
     {
         return trans("device.attributes.$attribute") . ': '
             . (($previous && $previous != $value) ? "$previous -> " : '')

lang/en/device.php

@@ -11,7 +11,9 @@
         'location' => 'Location',
         'os' => 'Device OS',
         'serial' => 'Serial',
+        'sysDescr' => 'sysDescr',
         'sysName' => 'sysName',
+        'sysObjectID' => 'sysObjectID',
         'version' => 'OS Version',
         'type' => 'Device type',
     ],