Move notification fetching from daily to a scheduled job (librenms#18247)

* Implement random scheduling times per host to prevents thundering herd problems

The randomization is stable per host, meaning it will always return the same "random" value per input.
This is needed so the scheduler doesn't run the same job multiple times

* Move notification fetching from daily to a scheduled job

* Apply fixes from StyleCI

* Apply fixes from StyleCI

---------

Co-authored-by: Tony Murray <[email protected]>

Author: Jellyfrog

app/Console/Commands/MaintenanceFetchRSS.php

@@ -0,0 +1,33 @@
+<?php
+
+namespace App\Console\Commands;
+
+use App\Console\LnmsCommand;
+use Illuminate\Support\Facades\Cache;
+use LibreNMS\Util\Notifications;
+
+class MaintenanceFetchRSS extends LnmsCommand
+{
+    /**
+     * The name of the console command.
+     *
+     * @var string
+     */
+    protected $name = 'maintenance:fetch-rss';
+
+    /**
+     * Execute the console command.
+     */
+    public function handle(): int
+    {
+        $lock = Cache::lock('notifications', 86000);
+        if ($lock->get()) {
+            Notifications::post();
+            $lock->release();
+
+            return 0;
+        }
+
+        return 1;
+    }
+}

daily.php

@@ -188,14 +188,6 @@
     }
 }
 
-if ($options['f'] === 'notifications') {
-    $lock = Cache::lock('notifications', 86000);
-    if ($lock->get()) {
-        Notifications::post();
-        $lock->release();
-    }
-}
-
 if ($options['f'] === 'bill_data') {
     // Deletes data older than XX months before the start of the last complete billing period
     $msg = "Deleting billing data more than %d month before the last completed billing cycle\n";

daily.sh

@@ -369,9 +369,7 @@ main () {
 
                 # List all tasks to do after pull in the order of execution
                 status_run 'Updating SQL-Schema' './lnms migrate --force --no-interaction --isolated'
-                status_run 'Updating submodules' "$DAILY_SCRIPT submodules"
                 status_run 'Cleaning up DB' "$DAILY_SCRIPT cleanup"
-                status_run 'Fetching notifications' "$DAILY_SCRIPT notifications"
                 status_run 'Caching PeeringDB data' "$DAILY_SCRIPT peeringdb"
             ;;
             cleanup)
@@ -392,16 +390,6 @@ main () {
                                "ports_purge")
                 call_daily_php "${options[@]}"
             ;;
-            submodules)
-                # Init+Update our submodules
-                git submodule --quiet init
-                git submodule --quiet update
-            ;;
-            notifications)
-                # Get notifications
-                options=("notifications")
-                call_daily_php "${options[@]}"
-            ;;
             peeringdb)
                 options=("peeringdb")
                 call_daily_php "${options[@]}"

routes/console.php

@@ -3,6 +3,7 @@
 use App\Console\Commands\MaintenanceCleanupNetworks;
 use App\Console\Commands\MaintenanceCleanupSyslog;
 use App\Console\Commands\MaintenanceFetchOuis;
+use App\Console\Commands\MaintenanceFetchRSS;
 use App\Jobs\PingCheck;
 use Illuminate\Support\Facades\Artisan;
 use Illuminate\Support\Facades\Cache;
@@ -184,6 +185,11 @@
     ->onOneServer()
     ->appendOutputTo($maintenance_log_file);
 
+Schedule::command(MaintenanceFetchRSS::class)
+    ->dailyAt(Time::pseudoRandomBetween('03:00', '03:59'))
+    ->onOneServer()
+    ->appendOutputTo($maintenance_log_file);
+
 Schedule::command(MaintenanceCleanupSyslog::class)
     ->dailyAt('03:30')
     ->onOneServer()