Disable docker service health file by default. (librenms#17444)

* Disable docker service health file by default.

* fix whitespace

Author: murrant

LibreNMS/service.py

@@ -105,7 +105,7 @@ def __init__(self, workers, frequency, calculate=None):
 
     watchdog_enabled = False
     watchdog_logfile = "logs/librenms.log"
-    health_file = "/tmp/librenms.health"
+    health_file = ""  # disabled by default
 
     def populate(self):
         config = LibreNMS.get_config_data(self.BASE_DIR)
@@ -415,8 +415,11 @@ def __init__(self):
             )
         else:
             logger.info("Watchdog is disabled.")
-        with open(self.config.health_file, "a") as f:
-            utime(self.config.health_file)
+        if self.config.health_file:
+            with open(self.config.health_file, "a") as f:
+                utime(self.config.health_file)
+        else:
+            logger.info("Service health file disabled.")
         self.systemd_watchdog_timer = LibreNMS.RecurringTimer(
             10, self.systemd_watchdog, "systemd-watchdog"
         )
@@ -920,7 +923,8 @@ def log_performance_stats(self):
             )
 
     def systemd_watchdog(self):
-        utime(self.config.health_file)
+        if self.config.health_file:
+            utime(self.config.health_file)
         if "systemd.daemon" in sys.modules:
             notify("WATCHDOG=1")
 

app/Console/Commands/HealthCheck.php

@@ -56,6 +56,13 @@ public function handle(): int
             if (getenv('SIDECAR_DISPATCHER')) {
                 // check dispatcher
                 $health_file = \LibreNMS\Config::get('service_health_file');
+
+                if (! $health_file) {
+                    $this->warn('Dispatcher service health file not enabled, set service_health_file');
+
+                    return 0;
+                }
+
                 if (! file_exists($health_file)) {
                     $this->error('Dispatcher service not started yet');
 

misc/config_definitions.json

@@ -6150,7 +6150,7 @@
             "units": "seconds"
         },
         "service_health_file": {
-            "default": "/tmp/librenms.health",
+            "default": "",
             "group": "poller",
             "section": "distributed",
             "order": 29,