showconfig.inc.php changed svn_log() and svn_diff() to Process() (librenms#16483)

* showconfig.inc.php changed svn from using functions in unsupported pecl svn package to using Process, like git

* Fixed formatting mistake in showconfig.inc.php

Added spaces around a '.'

* Resolved quotation marks showconfig.inc.php

Corrected my double quotes to single quotes.

* Added Config::locateBinary('svn') to showconfig.inc.php

Updated to use the recommended approach of using the LibreNMS execution finder code to use the full binary path instead of relying on the binary being in the path.

* Added is_executable($svn_binary) showconfig.inc.php

Verified that the executable and path exist before trying to run Process()

* Fixed my whitespace issues in showconfig.inc.php

Fixed my whitespace issues

---------

Co-authored-by: Neil Lathwood <[email protected]>

Author: mggaskill

includes/html/pages/device/showconfig.inc.php

@@ -20,27 +20,42 @@
             echo generate_link('Latest', ['page' => 'device', 'device' => $device['device_id'], 'tab' => 'showconfig']);
         }
 
-        if (Config::get('rancid_repo_type') == 'svn' && function_exists('svn_log')) {
-            $sep = ' | ';
-            $svnlogs = svn_log($rancid_file, SVN_REVISION_HEAD, null, 8);
-            $revlist = [];
-
-            foreach ($svnlogs as $svnlog) {
-                echo $sep;
-                $revlist[] = $svnlog['rev'];
+        if (Config::get('rancid_repo_type') == 'svn') {
+            $svn_binary = Config::locateBinary('svn');
+            if (is_executable($svn_binary)) {
+                $sep = ' | ';
 
-                if ($vars['rev'] == $svnlog['rev']) {
-                    echo '<span class="pagemenu-selected">';
+                $process = new Process([$svn_binary, 'log', '-l 8', '-q', '--xml', $rancid_file], $rancid_path);
+                $process->run();
+                $svnlogs_xmlstring = $process->getOutput();
+                $svnlogs = [];
+
+                $svnlogs_xml = simplexml_load_string($svnlogs_xmlstring);
+                foreach ($svnlogs_xml->logentry as $svnlogentry) {
+                    $rev = $svnlogentry['revision'];
+                    $ts = strtotime($svnlogentry->date);
+                    $svnlogs[] = ['rev' => $rev, 'date' => $ts];
                 }
 
-                $linktext = 'r' . $svnlog['rev'] . ' <small>' . date(Config::get('dateformat.byminute'), strtotime($svnlog['date'])) . '</small>';
-                echo generate_link($linktext, ['page' => 'device', 'device' => $device['device_id'], 'tab' => 'showconfig', 'rev' => $svnlog['rev']]);
+                $revlist = [];
 
-                if ($vars['rev'] == $svnlog['rev']) {
-                    echo '</span>';
-                }
+                foreach ($svnlogs as $svnlog) {
+                    echo $sep;
+                    $revlist[] = $svnlog['rev'];
 
-                $sep = ' | ';
+                    if ($vars['rev'] == $svnlog['rev']) {
+                        echo '<span class="pagemenu-selected">';
+                    }
+
+                    $linktext = 'r' . $svnlog['rev'] . ' <small>' . date(Config::get('dateformat.byminute'), $svnlog['date']) . '</small>';
+                    echo generate_link($linktext, ['page' => 'device', 'device' => $device['device_id'], 'tab' => 'showconfig', 'rev' => $svnlog['rev']]);
+
+                    if ($vars['rev'] == $svnlog['rev']) {
+                        echo '</span>';
+                    }
+
+                    $sep = ' | ';
+                }
             }
         }//end if
         if (Config::get('rancid_repo_type') == 'git') {
@@ -80,18 +95,16 @@
         print_optionbar_end();
 
         if (Config::get('rancid_repo_type') == 'svn') {
-            if (function_exists('svn_log') && in_array($vars['rev'], $revlist)) {
-                [$diff, $errors] = svn_diff($rancid_file, $vars['rev'] - 1, $rancid_file, $vars['rev']);
+            $svn_binary = Config::locateBinary('svn');
+            if (is_executable($svn_binary) && in_array($vars['rev'], $revlist)) {
+                $process = new Process([$svn_binary, 'diff', '-c', 'r' . $vars['rev'], $rancid_file], $rancid_path);
+                $process->run();
+                $diff = $process->getOutput();
                 if (! $diff) {
                     $text = 'No Difference';
                 } else {
-                    $text = '';
-                    while (! feof($diff)) {
-                        $text .= fread($diff, 8192);
-                    }
-
-                    fclose($diff);
-                    fclose($errors);
+                    $text = $diff;
+                    $previous_config = $vars['rev'] . '^';
                 }
             } else {
                 $fh = fopen($rancid_file, 'r');