User alert id for query. continue if missing alert (should never happen)

murrant · murrant · commit f5b946db351e · 2026-01-27T09:08:41.000-06:00
diff --git a/LibreNMS/Alert/RunAlerts.php b/LibreNMS/Alert/RunAlerts.php
@@ -512,14 +512,14 @@ public function runAlerts()
             }
 
             $status_check = DB::table('alerts')
-                ->where('alerts.rule_id', $alert['rule_id'])
+                ->where('alerts.id', $alert['id'])
                 ->leftJoin('devices', 'alerts.device_id', '=', 'devices.device_id')
                 ->first(['alerts.alerted', 'devices.ignore', 'devices.disabled']);
 
             if ($status_check === null) {
-                Log::error('Alert rule not found');
+                Log::error('Alert not found');
 
-                return;
+                continue;
             }
 
             if ($status_check->alerted == $alert['state']) {

Original file line number	Diff line number	Diff line change
`@@ -512,14 +512,14 @@ public function runAlerts()`
`512`	`512`	`}`
`513`	`513`
`514`	`514`	`$status_check = DB::table('alerts')`
`515`		`- ->where('alerts.rule_id', $alert['rule_id'])`
	`515`	`+ ->where('alerts.id', $alert['id'])`
`516`	`516`	`->leftJoin('devices', 'alerts.device_id', '=', 'devices.device_id')`
`517`	`517`	`->first(['alerts.alerted', 'devices.ignore', 'devices.disabled']);`
`518`	`518`
`519`	`519`	`if ($status_check === null) {`
`520`		`- Log::error('Alert rule not found');`
	`520`	`+ Log::error('Alert not found');`
`521`	`521`
`522`		`- return;`
	`522`	`+ continue;`
`523`	`523`	`}`
`524`	`524`
`525`	`525`	`if ($status_check->alerted == $alert['state']) {`