Various fixes when working with alert templates (librenms#18153)

Add mock data when validating template syntax

Author: murrant

database/seeders/DefaultAlertTemplateSeeder.php

@@ -48,7 +48,7 @@ public function run(): void
                     @if ($alert->faults)
                     Faults:
                     @foreach ($alert->faults as $key => $value)
-                    @php($unit = __("sensors.{$value["sensor_class"]}.unit"))
+                    @php($unit = __("sensors.{$value['sensor_class']}.unit"))
                     #{{ $key }}: {{ $value['sensor_descr'] ?? 'Sensor' }}
 
                     Current: {{ $value['sensor_current'].$unit }}

includes/html/forms/alert-templates.inc.php

@@ -21,6 +21,10 @@
  * @copyright 2014 f0o, LibreNMS
  * @license GPL
  */
+
+use App\Models\Device;
+use LibreNMS\Alert\AlertData;
+
 $status = 'error';
 
 if (! Auth::user()->hasGlobalAdmin()) {
@@ -29,10 +33,30 @@
     exit(json_encode($response));
 }
 
+$rules = explode(',', $vars['rules'] ?? '');
+
 try {
-    Blade::render($vars['template']);
-    Blade::render($vars['title']);
-    Blade::render($vars['title_rec']);
+    // create some test data to check the template
+    $test_data = [
+        'id' => 0,
+        'rule' => 'test',
+        'name' => 'Test Rule',
+        'severity' => 'critical',
+        'extra' => '',
+        'disabled' => 0,
+        'query' => '',
+        'builder' => [],
+        'proc' => '',
+        'invert_map' => 0,
+        'notes' => '',
+    ];
+    $test_device = new Device(['hostname' => 'test']);
+    $test_device->device_id = 0;
+    $test_data['alert'] = new AlertData(AlertData::testData($test_device));
+
+    Blade::render($vars['template'], $test_data);
+    Blade::render($vars['title'], $test_data);
+    Blade::render($vars['title_rec'], $test_data);
 
     $template_id = 0;
     $template_newid = 0;
@@ -68,14 +92,13 @@
         if ($status == 'ok') {
             $alertRulesOk = true;
             dbDelete('alert_template_map', 'alert_templates_id = ?', [$template_id]);
-            $rules = explode(',', $vars['rules']);
-            if ($rules !== false) {
-                foreach ($rules as $rule_id) {
-                    if (! dbInsert(['alert_rule_id' => $rule_id, 'alert_templates_id' => $template_id], 'alert_template_map')) {
-                        $alertRulesOk = false;
-                    }
+
+            foreach ($rules as $rule_id) {
+                if (! dbInsert(['alert_rule_id' => $rule_id, 'alert_templates_id' => $template_id], 'alert_template_map')) {
+                    $alertRulesOk = false;
                 }
             }
+
             if ($alertRulesOk) {
                 $status = 'ok';
                 $message = 'Alert template has been ' . ($create ? 'created' : 'updated') . ' and attached rules have been updated.';
@@ -92,6 +115,6 @@
     $message .= $e->getMessage();
 }
 
-$response = ['status' => htmlentities($status), 'message' => htmlentities($message), 'newid' => $template_newid];
+$response = ['status' => htmlentities($status), 'message' => htmlentities($message), 'newid' => $template_newid ?? null];
 
 echo json_encode($response, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE);

includes/html/modal/alert_rule_list.inc.php

@@ -52,9 +52,7 @@
                         <?php
                         $alert_rules = dbFetchRows('SELECT * FROM alert_rules order by name');
                         foreach ($alert_rules as $rule) {
-                            if (empty($rule['builder'])) {
-                                $rule_display = $rule['rule'];
-                            } elseif (isset($rule_extra['options']['override_query']) && $rule_extra['options']['override_query'] === 'on') {
+                            if (isset($rule_extra['options']['override_query']) && $rule_extra['options']['override_query'] === 'on') {
                                 $rule_display = 'Custom SQL Query';
                             } else {
                                 $rule_display = QueryBuilderParser::fromJson($rule['builder'])->toSql(false);

includes/html/print-alert-rules.php

@@ -60,7 +60,7 @@
         }
 
         $qb = QueryBuilderParser::fromJson($add_rule['builder']);
-        
+
         $insert = [
             'builder' => json_encode($add_rule['builder']),
             'query' => $qb->toSql(),
@@ -363,12 +363,12 @@
 
     // Extra
 
-    echo '<td><small>Max: ' . $rule_extra['count'] . '<br />Delay: ' . $rule_extra['delay'] . '<br />Interval: ' . $rule_extra['interval'] . '</small></td>';
+    echo '<td><small>Max: ' . $rule_extra['count'] . '<br />Delay: ' . $rule_extra['delay'] . '<br />Interval: ' . ($rule_extra['interval'] ?? '') . '</small></td>';
 
     // Rule
 
     echo "<td class='col-sm-4'>";
-    if ($rule_extra['invert'] === true) {
+    if (isset($rule_extra['invert']) && $rule_extra['invert'] === true) {
         echo '<strong><em>Inverted</em></strong> ';
     }