not updating dead notes for transposition

Author: alexpavlov96

src/engraving/dom/note.cpp

@@ -2139,6 +2139,16 @@ void Note::updateAccidental(AccidentalState* as)
 {
     int absLine = absStep(tpc(), epitch());
 
+    if (deadNote()) {
+        if (m_accidental) {
+            score()->undoRemoveElement(m_accidental);
+        }
+
+        as->setForceRestateAccidental(absLine, false);
+        updateRelLine(absLine, true);
+        return;
+    }
+
     // Ensure m_centOffset and microtonal accidental match (they can mismatch when switching from TAB)
     if (muse::RealIsNull(m_centOffset)) {
         if (m_accidental && !muse::RealIsNull(Accidental::subtype2centOffset(m_accidental->accidentalType()))) {
@@ -4104,6 +4114,10 @@ int Note::stringOrLine() const
 
 bool Note::transposeDiatonic(int interval, bool keepAlterations, bool useDoubleAccidentals)
 {
+    if (deadNote()) {
+        return true;
+    }
+
     // compute note current absolute step
     int alter;
     Fraction tick = chord()->segment()->tick();
@@ -4148,6 +4162,10 @@ bool Note::transposeDiatonic(int interval, bool keepAlterations, bool useDoubleA
 
 bool Note::transpose(Interval interval, bool useDoubleSharpsFlats)
 {
+    if (deadNote()) {
+        return true;
+    }
+
     int npitch = pitch() + interval.chromatic;
     if (!pitchIsValid(npitch)) {
         return false;

src/engraving/dom/stringdata.cpp

@@ -246,6 +246,9 @@ void StringData::fretChords(Chord* chord) const
         nString = nNewString = note->string();
         nFret   = nNewFret   = note->fret();
         note->setFretConflict(false);           // assume no conflicts on this note
+        if (note->deadNote()) {
+            continue;
+        }
         // if no fretting (any invalid fretting has been erased by sortChordNotes() )
         if (nString == INVALID_STRING_INDEX /*|| nFret == INVALID_FRET_INDEX || getPitch(nString, nFret) != note->pitch()*/) {
             const CapoParams& capo = note->staff()->capo(note->tick());
@@ -518,6 +521,9 @@ void StringData::sortChordNotesUseSameString(const Chord* chord, int pitchOffset
         if (note->displayFret() != Note::DisplayFretOption::NoHarmonic) {
             continue;
         }
+        if (note->deadNote()) {
+            continue;
+        }
         if (note->string() < 0 || note->fret() < 0) {
             anyReset = true;
             continue;
@@ -538,6 +544,9 @@ void StringData::sortChordNotesUseSameString(const Chord* chord, int pitchOffset
             if (note->displayFret() != Note::DisplayFretOption::NoHarmonic) {
                 continue;
             }
+            if (note->deadNote()) {
+                continue;
+            }
             note->setString(INVALID_STRING_INDEX);
             note->setFret(INVALID_FRET_INDEX);
         }
@@ -576,8 +585,8 @@ void StringData::sortChordNotes(std::map<int, Note*>& sortedNotes, const Chord*
         int pitch = getPitch(string, noteFret, pitchOffsetAt(chord->staff(), chord->tick(), string));
         // if note not fretted yet or current fretting no longer valid,
         // use most convenient string as key
-        if (!note->negativeFretUsed() && (string <= INVALID_STRING_INDEX || noteFret <= INVALID_FRET_INDEX
-                                          || (pitchIsValid(pitch) && pitch != note->pitch()))) {
+        if (!note->deadNote() && !note->negativeFretUsed() && (string <= INVALID_STRING_INDEX || noteFret <= INVALID_FRET_INDEX
+                                                               || (pitchIsValid(pitch) && pitch != note->pitch()))) {
             note->setString(INVALID_STRING_INDEX);
             note->setFret(INVALID_FRET_INDEX);
         }

src/engraving/editing/transpose.cpp

@@ -538,6 +538,10 @@ Interval Transpose::keydiff2Interval(Key oKey, Key nKey, TransposeDirection dir)
 bool Transpose::transposeNote(Note* note, TransposeMode mode, int transposeInterval, bool trKeys, bool useDoubleSharpsFlats,
                               Interval interval)
 {
+    if (note->deadNote()) {
+        return true;
+    }
+
     if (mode == TransposeMode::DIATONICALLY) {
         return note->transposeDiatonic(transposeInterval, trKeys, useDoubleSharpsFlats);
     }