Fix read after free on removed hook

mike-spa · mike-spa · commit 0e1d7d42efb4 · 2026-01-13T14:48:59.000+01:00
diff --git a/src/engraving/rendering/score/beamlayout.cpp b/src/engraving/rendering/score/beamlayout.cpp
@@ -693,6 +693,9 @@ void BeamLayout::createBeams(LayoutContext& ctx, Measure* measure)
                             if (prevCR->isChord()) {
                                 if (Hook* hook = toChord(prevCR)->hook()) {
                                     ctx.mutDom().doUndoRemoveElement(hook);
+                                    prevCR->segment()->staffShape(prevCR->vStaffIdx()).remove_if([hook](const ShapeElement& el) {
+                                        return el.item() == hook;
+                                    });
                                 }
                             }
                             //a1 = beam ? beam->elements().front() : prevCR;

Original file line number	Diff line number	Diff line change
`@@ -693,6 +693,9 @@ void BeamLayout::createBeams(LayoutContext& ctx, Measure* measure)`
`693`	`693`	`if (prevCR->isChord()) {`
`694`	`694`	`if (Hook* hook = toChord(prevCR)->hook()) {`
`695`	`695`	`ctx.mutDom().doUndoRemoveElement(hook);`
	`696`	`+ prevCR->segment()->staffShape(prevCR->vStaffIdx()).remove_if([hook](const ShapeElement& el) {`
	`697`	`+ return el.item() == hook;`
	`698`	`+ });`
`696`	`699`	`}`
`697`	`700`	`}`
`698`	`701`	`//a1 = beam ? beam->elements().front() : prevCR;`