Fix dive palette position

Author: miiizen

src/palette/internal/palettecompat.cpp

@@ -60,6 +60,9 @@ static const std::unordered_set<ActionIconType> BENDS_ACTION_TYPES = {
     ActionIconType::PRE_BEND,
     ActionIconType::GRACE_NOTE_BEND,
     ActionIconType::SLIGHT_BEND,
+};
+
+static const std::unordered_set<ActionIconType> DIVES_ACTION_TYPES = {
     ActionIconType::DIVE,
     ActionIconType::PRE_DIVE,
     ActionIconType::DIP,
@@ -239,6 +242,7 @@ void PaletteCompat::addNewGuitarItems(Palette& guitarPalette, Score* paletteScor
     bool containsFFrame = false;
     bool containsTapping = false;
     bool containsHammerOnPullOff = false;
+    bool containsGuitarDives = false;
 
     for (const PaletteCellPtr& cell : guitarPalette.cells()) {
         const ElementPtr element = cell->element;
@@ -255,6 +259,9 @@ void PaletteCompat::addNewGuitarItems(Palette& guitarPalette, Score* paletteScor
             if (muse::contains(BENDS_ACTION_TYPES, icon->actionType())) {
                 containsGuitarBends = true;
             }
+            if (muse::contains(DIVES_ACTION_TYPES, icon->actionType())) {
+                containsGuitarDives = true;
+            }
             if (icon->actionType() == ActionIconType::FFRAME) {
                 containsFFrame = true;
             }
@@ -287,6 +294,10 @@ void PaletteCompat::addNewGuitarItems(Palette& guitarPalette, Score* paletteScor
         guitarPalette.insertActionIcon(defaultPosition, ActionIconType::PRE_BEND, "pre-bend", 1.25);
         guitarPalette.insertActionIcon(defaultPosition, ActionIconType::GRACE_NOTE_BEND, "grace-note-bend", 1.25);
         guitarPalette.insertActionIcon(defaultPosition, ActionIconType::SLIGHT_BEND, "slight-bend", 1.25);
+    }
+
+    if (!containsGuitarDives) {
+        int defaultPosition = std::min(12, guitarPalette.cellsCount());
         guitarPalette.insertActionIcon(defaultPosition, ActionIconType::DIVE, "dive", 1.25);
         guitarPalette.insertActionIcon(defaultPosition, ActionIconType::PRE_DIVE, "pre-dive", 1.25);
         guitarPalette.insertActionIcon(defaultPosition, ActionIconType::DIP, "dip", 1.25);