Fixed a recursive call to the async::processMessages

Author: igorkorsukov

src/framework/audio/engine/internal/export/soundtrackwriter.cpp

@@ -163,7 +163,7 @@ Ret SoundTrackWriter::generateAudioData()
 
         //! NOTE It is necessary for cancellation to work
         //! and for information about the audio signal to be transmitted.
-        async::processMessages(thisThId);
+        //async::processMessages(thisThId);
         rpcChannel()->process();
     }
 

src/framework/audio/engine/internal/synthesizers/fluidsynth/fluidsynth.cpp

@@ -37,6 +37,8 @@ using namespace muse::audio;
 using namespace muse::audio::synth;
 using namespace muse::mpe;
 
+static constexpr bool FLUID_DEBUG = false;
+
 static constexpr double FLUID_GLOBAL_VOLUME_GAIN = 4.8;
 static constexpr int DEFAULT_MIDI_VOLUME = 100;
 static constexpr msecs_t MIN_NOTE_LENGTH = 10;
@@ -90,7 +92,9 @@ Ret FluidSynth::init(const OutputSpec& spec)
             LOGI() << message;
         } break;
         case FLUID_DBG:  {
-            LOGD() << message;
+            if (FLUID_DEBUG) {
+                LOGD() << message;
+            }
         } break;
         }
 

src/framework/global/thirdparty/kors_async/async/async.h

@@ -112,6 +112,7 @@ class Async
         m_queues.push_back(d);
 
         d->queue.port2()->onMessage([d](const CallMsg& m) {
+            assert(m.func && "m.func is nullptr");
             if (m.receiver) {
                 if (d->isConnected(m.receiver)) {
                     m.func->call(nullptr);
@@ -135,7 +136,10 @@ class Async
         {
             Call func;
             Func(const Call& f = nullptr)
-                : func(f) {}
+                : func(f)
+            {
+                assert(func && "callback is nullptr");
+            }
 
             void call(const void*) override
             {

src/framework/global/thirdparty/kors_async/async/internal/rpcqueue.h

@@ -74,6 +74,7 @@ class RpcPort
     std::vector<T> m_buffer;
     std::queue<T> m_pending;
     std::function<void(const T&)> m_handler;
+    bool m_isProcessing = false;
 
 public:
 
@@ -94,6 +95,9 @@ class RpcPort
 
         assert(m_connPort);
 
+        assert(!m_isProcessing && "Recursive processing of messages is not allowed");
+        m_isProcessing = true;
+
         // receive messages
         m_buffer.clear();
         bool ok = m_connPort->m_queue.tryPopAll(m_buffer);
@@ -102,6 +106,8 @@ class RpcPort
                 m_handler(item);
             }
         }
+
+        m_isProcessing = false;
     }
 
     size_t countToSend() const

src/project/qml/MuseScore/Project/internal/Export/exportdialogmodel.cpp

@@ -24,6 +24,7 @@
 #include <algorithm>
 
 #include <QItemSelectionModel>
+#include <QTimer>
 
 #include "async/async.h"
 #include "translation.h"
@@ -425,7 +426,11 @@ bool ExportDialogModel::exportScores()
                    shouldDestinationFolderBeOpenedOnExport() };
 
     std::shared_ptr<IExportProjectScenario> scenario = exportProjectScenario();
-    async::Async::call(nullptr, [scenario, params]() {
+
+    //! NOTE We can't use Async here
+    // because the async::processMessgaes is called deep within the functions,
+    // and this can't be done in Async's callback.
+    QTimer::singleShot(0, [scenario, params]() {
         scenario->exportScores(params.notations, params.exportPath, params.selectedUnitType, params.openFolderOnExport);
     });