Merge pull request #32842 from CubikingChill/select-instrument-crash

Fix crash when clicking "select instrument" from "change instrument" during playback (#32078)

Author: RomanPudashkin

src/instrumentsscene/internal/instrumentsactionscontroller.cpp

@@ -60,12 +60,22 @@ void InstrumentsActionsController::changeInstrument()
         return;
     }
 
-    const mu::engraving::EngravingItem* element = master->notation()->interaction()->selection()->element();
-    const mu::engraving::InstrumentChange* instrumentChange = element ? mu::engraving::toInstrumentChange(element) : nullptr;
-    if (!instrumentChange) {
+    INotationPtr notation = context()->currentNotation();
+    IF_ASSERT_FAILED(notation) {
         return;
     }
 
+    const mu::engraving::EngravingItem* element = notation->interaction()->hitElementContext().element;
+    if (!element) {
+        element = notation->interaction()->selection()->element();
+    }
+
+    if (!element || !element->isInstrumentChange()) {
+        return;
+    }
+
+    const mu::engraving::InstrumentChange* instrumentChange = mu::engraving::toInstrumentChange(element);
+
     InstrumentKey key;
     key.instrumentId = instrumentChange->instrument()->id();
     key.partId = instrumentChange->part()->id();