Fix crash when dragging element from more palette to parent

Author: mathesoncalum

src/palette/qml/MuseScore/Palette/internal/PaletteTree.qml

@@ -276,7 +276,8 @@ StyledListView {
 
         property var control: null
         property var model: null
-        property alias isOpened: palettePopup.active
+
+        readonly property bool isOpened: palettePopup.active && palettePopup.item.isOpened
 
         sourceComponent: MoreElementsPopup {
             id: moreElementsPopup
@@ -320,7 +321,6 @@ StyledListView {
 
             onClosed: {
                 enablePaletteAnimations = false;
-                palettePopup.active = false;
             }
 
             function scrollToPopupBottom() {
@@ -349,25 +349,28 @@ StyledListView {
         }
 
         function close() {
-            if (palettePopup.active) {
-                palettePopup.item.close();
+            if (palettePopup.isOpened) {
+                palettePopup.item.close()
             }
         }
 
         function toggleOpened(model, control, parent) {
-            if (palettePopup.active) {
-                palettePopup.close();
-                return;
+            if (palettePopup.isOpened) {
+                palettePopup.close()
+                return
             }
 
-            palettePopup.parent = parent;
-            palettePopup.model = model;
-            palettePopup.control = control;
+            // Force a full re-load of the component (ensures the geometry updates, etc.)
+            palettePopup.active = false
+
+            palettePopup.parent = parent
+            palettePopup.model = model
+            palettePopup.control = control
 
-            palettePopup.active = true;
-            palettePopup.item.setParentItem(parent);
+            palettePopup.active = true
+            palettePopup.item.setParentItem(parent)
 
-            palettePopup.item.toggleOpened();
+            palettePopup.item.toggleOpened()
         }
     }
 
@@ -407,7 +410,7 @@ StyledListView {
             }
 
             Component.onDestruction: {
-                if (palettePopup.active && palettePopup.model === model) {
+                if (palettePopup.isOpened && palettePopup.model === model) {
                     palettePopup.close()
                 }
             }