XmlReader: attempt to show correct line number for "custom" errors

cbjeukendrup · cbjeukendrup · commit bde58382c5da · 2025-02-09T03:12:26.000+01:00
diff --git a/src/framework/global/serialization/xmlstreamreader.cpp b/src/framework/global/serialization/xmlstreamreader.cpp
@@ -474,6 +474,10 @@ double XmlStreamReader::readDouble(bool* ok)
 
 int64_t XmlStreamReader::lineNumber() const
 {
+    if (!m_xml->doc.Error() && m_xml->node) {
+        return m_xml->node->GetLineNum();
+    }
+
     return m_xml->doc.ErrorLineNum();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -474,6 +474,10 @@ double XmlStreamReader::readDouble(bool* ok)`
`474`	`474`
`475`	`475`	`int64_t XmlStreamReader::lineNumber() const`
`476`	`476`	`{`
	`477`	`+ if (!m_xml->doc.Error() && m_xml->node) {`
	`478`	`+ return m_xml->node->GetLineNum();`
	`479`	`+ }`
	`480`	`+`
`477`	`481`	`return m_xml->doc.ErrorLineNum();`
`478`	`482`	`}`
`479`	`483`