Recall key & remove existing logic

This sets the key to the key at the point of selection in the score which isn't very useful

Author: miiizen

src/notation/view/widgets/transposedialog.cpp

@@ -59,7 +59,6 @@ TransposeDialog::TransposeDialog(QWidget* parent)
     });
     setEnableTransposeChordNames(hasChordNames);
 
-    setKey(firstPitchedStaffKey());
     restorePreviousSettings();
 
     connect(this, &TransposeDialog::accepted, this, &TransposeDialog::apply);
@@ -252,38 +251,6 @@ void TransposeDialog::apply()
     }
 }
 
-Key TransposeDialog::firstPitchedStaffKey() const
-{
-    mu::engraving::staff_idx_t startStaffIdx = 0;
-    mu::engraving::staff_idx_t endStaffIdx   = 0;
-    Fraction startTick = Fraction(0, 1);
-    INotationSelectionRangePtr range = selection()->range();
-
-    if (selection()->isRange()) {
-        startStaffIdx = range->startStaffIndex();
-        endStaffIdx = range->endStaffIndex();
-        startTick = range->startTick();
-    }
-
-    Key key = Key::C;
-
-    for (const Part* part : notation()->parts()->partList()) {
-        for (const Staff* staff : part->staves()) {
-            if (staff->idx() < startStaffIdx || staff->idx() > endStaffIdx) {
-                continue;
-            }
-
-            if (staff->isPitchedStaff(startTick)) {
-                key = staff->concertKey(startTick);
-
-                break;
-            }
-        }
-    }
-
-    return key;
-}
-
 void TransposeDialog::setEnableTransposeKeys(bool val)
 {
     transposeKeys->setEnabled(val);
@@ -380,6 +347,7 @@ void TransposeDialog::restorePreviousSettings()
     setInterval(options.interval);
     setUseDoubleSharpsFlats(options.needTransposeDoubleSharpsFlats);
     setTransposeChordNames(options.needTransposeChordNames);
+    setKey(options.key);
 }
 
 TransposeOptions& TransposeDialog::lastUsedOptions()

src/notation/view/widgets/transposedialog.h

@@ -55,7 +55,6 @@ private slots:
     INotationSelectionPtr selection() const;
     INotationInteractionPtr interaction() const;
 
-    Key firstPitchedStaffKey() const;
     void setEnableTransposeKeys(bool val);
     void setEnableTransposeToKey(bool val);
     void setEnableTransposeChordNames(bool val);
@@ -71,9 +70,9 @@ private slots:
     void setKey(Key k);
     bool useDoubleSharpsFlats() const;
 
+    void restorePreviousSettings();
     void setDirection(TransposeDirection direction);
     void setInterval(int interval);
-    void restorePreviousSettings();
     void setUseDoubleSharpsFlats(bool val);
     void setTransposeChordNames(bool val);