Instrument names on hidden staves affect system indentation

[Reedbeta]

Issue type

Engraving bug (incorrect score rendering)

Description with steps to reproduce

On systems past the first one, horizontal space is reserved for all instrument names even if the staves are not visible.

Steps to repro:

1. Create a new score with two staves.
2. Set both the "long" and "short" instrument names for the second staff to something lengthy (this is to exaggerate the effect).
3. Turn on "automatically hide empty staves" under the score appearance properties, and turn off "don't hide empty staves in first system".

Result: the first system has a normal amount of space for the instrument name, but the second and later systems have excessive indentation (see screenshot below).

Here is the score file: instrument names test.zip

Supporting files, videos and screenshots

In which versions of MuseScore Studio is this issue present?

4.6.5, master

Regression

I was unable to check

Operating system

Windows 10

Additional context

No response

Checklist

• This report follows the guidelines for reporting bugs and issues
• I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
• I have attached all requested files and information to this report
• I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible

[LittleWishy]

This issue has existed for a while; if I recall correctly it dates back to 4.5. Currently using 4.6.2 and can confirm the issue is prevalent there.

[Jojo-Schmitz]

Same issue in 4.0.1, there additonally an issue with the 1st system

4.1.0 has the issue only with the 2nd and subsequent systems. (And on Windows 11)

ISTR the same issue with Mu3, but can't reproduce currently

[bakajikara]

As the author of the issue #15638 and the fix #16967, I previously limited the fix to the first system only, specifically to avoid breaking the global alignment design of #8968.
​The guidance for fixing this current issue is:
The global indentation for abbreviated names should be determined by the maximum width of names that are actually visible in at least one system. Hidden staves should be excluded from this "global maximum" calculation to prevent unnecessary blank space while still maintaining the consistency required by #8968.

[Reedbeta]

Hmm, also just found #22649 which suggests that this is by design to break a potential infinite loop / cyclic dependency in layout calculation. 😕

Regarding the requirement for multiple systems to align with each other, I'd argue that this should only apply within a single page. (In vertical continuous view, it would make more sense for it to apply across the entire score.)

In any case it seems weird that the current behavior allows for 2nd-and-later systems to be indented more than the first system (normally the opposite is true).