Mac: Build fails with "bufferutil.node ... same in both x64 and arm64 builds"

[benbucksch]

https://github.com/mustang-im/mustang/actions/runs/22345203463/job/64657926916

Detected file "Contents/Resources/app.asar.unpacked/node_modules/bufferutil/prebuilds/darwin-arm64/bufferutil.node" that's the same in both x64 and arm64 builds and not covered by the x64ArchFiles rule: "undefined" failedTask=build stackTrace=Error: Detected file "Contents/Resources/app.asar.unpacked/node_modules/bufferutil/prebuilds/darwin-arm64/bufferutil.node" that's the same in both x64 and arm64 builds and not covered by the x64ArchFiles rule: "undefined"

[benbucksch]

Could be triggered (not caused) by the electron-builder upgrade.
The cause seems to be that the bufferutil.node file is the ARM executable on Mac Intel, which probably made Mac Intel fail, and we never noticed.

[jermy-c]

Seems to be this issue: electron/universal#51

[benbucksch]

from that bug report: electron/universal#51 (comment)

Can you please check whether the bufferutil.node is universal and works for both Intel and ARM? or did the wrong file get downloaded.

Note: the other guys in the bugc are taking about rebuilding. we don't have that issue on CI, because there will be no old files lying around. our issue is that the wing file gets downloaded. or it's a false positive, but unlikely.

as i said, this is likely an actual bug in our build system, and electron-buildee merely detected it

[jermy-c]

Can you please check whether the bufferutil.node is universal and works for both Intel and ARM? or did the wrong file get downloaded.

All prebuilds for all OSs and Archs are included in the bufferutil but the build process is different for the newer electron-builder. It seems like it tries to get only what it needs instead of copying the entire node_modules folder(older version seems to be doing that) and then merge the .node files but it doesn't know how to merge them.

[benbucksch]

Are you positive that the bufferutils.node file (not the node_modules/ directory) contains the executable for both Intel and ARM? If so, then you can override the error (link).

Or is the electron-builder picking the wrong executable file from the node_modules/ directory? If so, then we need to fork and fix it and submit a PR.

Whatever the case, can you please submit some fix today that makes at least Mac ARM builds work? This is blocking the release.

[benbucksch]

Jeremy said in chat:

electron-builder ... only picks out the required .node files but it's not doing it correctly

[jermy-c]

Are you positive that the bufferutils.node file (not the node_modules/ directory) contains the executable for both Intel and ARM? If so, then you can electron/universal#51 (comment) (link).

All prebuilds are included when the package is installed. The directory structure is bufferutil/prebuilds/[OS]-[Arch]/bufferutil.node. All of them are named bufferutil.node just in different directories.