vCard: Import nasty samples

[benbucksch]

all.zip, vCard in ZIP, source: vcard-test-suite

• Extract the above vcards and try to import them into Mustang
• Fix any bugs discovered
• Implemented Quoted-Printable (only if that's relevant in real life)

[NeilRashbrook]

A zipped flat file of all the cards concatenated is the worst possible format you could have chosen...

[benbucksch]

I also linked the original, with the individual files. Be my guest...

[NeilRashbrook]

7.8.vcf doesn't contain a BEGIN:VCARD, which the parser doesn't like.
9.6.vcf doesn't contain an END:VCARD, just an E, which the parser chokes on.
5.14.vcf and 12.10.vcf fail completely due to containing quoted printable. This is only supported in vCards of version 2.1 and earlier, so it's not important to implement.
4.9.vcf, 13.10.vcf and eds-quoted-printable.2.vcf also contain quoted printable, but here the parser returns garbage instead.
964 of these vcf files don't have BEGIN in upper case, which the parser doesn't check for. (It doesn't check for END in upper case either, but this doesn't prevent the parse from completing.)
Other than that the parser produced results for all of the cards.

[NeilRashbrook]

I since see you fixed the BEGIN/END issue in 4d905e7...

[benbucksch]

Please also test that this works - as well as reasonably possible - with the concatenated vcards. This is how entire addressbooks are stored, and that's why this was the test case that I attached.

[benbucksch]

A zipped flat file of all the cards concatenated is the worst possible format you could have chosen...

(FYI, the ZIP was only because github does not allow me to attach raw vcf files, so I had to zip it. The ZIPing is only for attaching it here on github, not for usage in the app.)

[NeilRashbrook]

7.8.vcf doesn't contain a BEGIN:VCARD, which the parser doesn't like.

FYI 7.8.vcf is otherwise identical to 1.9.vcf.

Please also test that this works - as well as reasonably possible - with the concatenated vcards.

May I exclude the problematic cards 5.14.vcf, 7.8.vcf, 9.6.vcf and 12.10.vcf?

[benbucksch]

In the concatenation, it is OK to assume that BEGIN/END are at least syntactically valid, so you can exclude 7.8 and 9.6.

Within a vcard, when the properties are invalid or outdated or we don't understand them, we should log an error, but continue to parse the rest of properties and the rest of vcards. So, it's OK to not get a contact out of 5.14 and 12.10, but we need to log an error and the rest of the cards still need to work.

[benbucksch]

If only uncritical properties cannot be parsed, we still need to salvage the rest of the contact.

[benbucksch]

Note that #1047 is far more important and urgent, because it makes CardDAV fail entirely even in correct cases.