Skip to content

Commit 9c54204

Browse files
committed
test: update snapshots, login steps, and fixes for test configurations
1 parent 12520d9 commit 9c54204

File tree

5 files changed

+12
-31
lines changed

5 files changed

+12
-31
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ jobs:
124124

125125
- name: Get playwright version
126126
id: playwright-version
127-
run: echo "version=$(pnpm info @playwright/test version)" >> $GITHUB_OUTPUT
127+
run: echo "version=$(pnpm info playwright version)" >> $GITHUB_OUTPUT
128128

129129
- name: Cache playwright binary
130130
id: cache-playwright-binary

playwright/specs/article.spec.ts

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,21 @@
1-
import { ArticleDetailPageObject } from 'page-objects/article-detail.page-object.ts'
2-
import { EditArticlePageObject } from 'page-objects/edit-article.page-object.ts'
3-
import type { Article } from 'src/services/api.ts'
4-
import { Route } from '../constant.ts'
1+
import { ArticleDetailPageObject } from 'page-objects/article-detail.page-object'
2+
import { EditArticlePageObject } from 'page-objects/edit-article.page-object'
3+
import type { Article } from 'src/services/api'
4+
import { Route } from '../constant'
55
import { expect, test } from '../extends'
6-
import { formatHTML, formatJSON } from '../utils/prettify.ts'
6+
import { formatHTML, formatJSON } from '../utils/prettify'
77

88
test.beforeEach(async ({ conduit }) => {
99
await conduit.intercept('GET', /articles\?limit/, { fixture: 'articles.json' })
1010
await conduit.intercept('GET', /tags/, { fixture: 'tags.json' })
1111
await conduit.intercept('GET', /profiles\/.+/, { fixture: 'profile.json' })
12-
13-
await conduit.login()
1412
})
1513

1614
test.describe('post article', () => {
1715
let editArticlePage!: EditArticlePageObject
1816

19-
test.beforeEach(({ page }) => {
17+
test.beforeEach(async ({ conduit, page }) => {
18+
await conduit.login()
2019
editArticlePage = new EditArticlePageObject(page)
2120
})
2221

@@ -56,6 +55,7 @@ test.describe('post article', () => {
5655
test.describe('delete article', () => {
5756
for (const position of ['banner', 'article footer'] as const) {
5857
test(`delete article from ${position}`, async ({ page, conduit }) => {
58+
await conduit.login()
5959
const articlePage = new ArticleDetailPageObject(page)
6060
const waitForArticle = await articlePage.intercept('GET', /articles\/.+/, { fixture: 'article.json' })
6161
await conduit.goto(Route.ArticleDetail)
@@ -102,12 +102,13 @@ test.describe('favorite article', () => {
102102
page.getByRole('button', { name: 'Favorite article' }).first().click(),
103103
])
104104

105-
await expect(page.getByRole('button', { name: 'Favorite article' }).first()).toHaveClass('btn-primary')
105+
await expect(page.getByRole('button', { name: 'Favorite article' }).first()).toContainClass('btn-primary')
106106
})
107107
})
108108

109109
test.describe('tag', () => {
110110
test.beforeEach(async ({ conduit }) => {
111+
await conduit.login()
111112
await conduit.intercept('GET', /articles\?tag=butt/, { fixture: 'articles-of-tag.json' })
112113
})
113114

playwright/specs/article.spec.ts-snapshots/markdown-render-chromium-darwin.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div id="article-content" data-testid="article-body" class="col-md-12">
1+
<div id="article-content" class="col-md-12" data-testid="article-body">
22
<h1>Article body</h1>
33
<p>This is <strong>Strong</strong> text</p>
44
</div>

playwright/specs/article.spec.ts-snapshots/popular-tags-in-home-page-firefox-darwin.json

Lines changed: 0 additions & 10 deletions
This file was deleted.

playwright/specs/article.spec.ts-snapshots/popular-tags-in-home-page-webkit-darwin.json

Lines changed: 0 additions & 10 deletions
This file was deleted.

0 commit comments

Comments
 (0)