fix(log): remove remaining format specifiers and fix malformed log calls

mutouyun · mutouyun · commit 2b1ed4bc5146 · 2025-12-15T10:06:52.000Z
- src/libipc/platform/posix/condition.h:
  * Replace all %d and %s format specifiers with stream-based syntax
  * Update log.error() calls to use proper streaming (e.g., "[", eno, "]")

- src/libipc/platform/posix/semaphore_impl.h:
  * Remove %d format specifiers from log.error() calls
  * Fix malformed parentheses (e.g., .c_str(, ""))
  * Remove unnecessary empty string arguments
  * Use stream-based logging consistently

- src/libipc/platform/win/mutex.h:
  * Fix malformed GetLastError() parentheses
  * Remove %lu format specifier, use explicit cast instead
  * Update to stream-based logging syntax

- src/libipc/platform/win/semaphore.h:
  * Fix malformed GetLastError() parentheses
  * Remove %lu format specifier, use explicit cast instead
  * Update to stream-based logging syntax

All format specifiers (%d, %s, %zd, %p, %lu) have been removed and replaced
with proper C++ stream-based logging that is type-safe and consistent with
the new imp/log interface.
diff --git a/src/libipc/platform/posix/condition.h b/src/libipc/platform/posix/condition.h
@@ -23,7 +23,7 @@ class condition {
     pthread_cond_t *acquire_cond(char const *name) {
         LIBIPC_LOG();
         if (!shm_.acquire(name, sizeof(pthread_cond_t))) {
-            log.error("[acquire_cond] fail shm.acquire: %s", name);
+            log.error("[acquire_cond] fail shm.acquire: ", name);
             return nullptr;
         }
         return static_cast<pthread_cond_t *>(shm_.get());
@@ -62,17 +62,17 @@ class condition {
         int eno;
         pthread_condattr_t cond_attr;
         if ((eno = ::pthread_condattr_init(&cond_attr)) != 0) {
-            log.error("fail pthread_condattr_init[%d]", eno);
+            log.error("fail pthread_condattr_init[", eno, "]");
             return false;
         }
         LIBIPC_UNUSED auto guard_cond_attr = guard([&cond_attr] { ::pthread_condattr_destroy(&cond_attr); });
         if ((eno = ::pthread_condattr_setpshared(&cond_attr, PTHREAD_PROCESS_SHARED)) != 0) {
-            log.error("fail pthread_condattr_setpshared[%d]", eno);
+            log.error("fail pthread_condattr_setpshared[", eno, "]");
             return false;
         }
         *cond_ = PTHREAD_COND_INITIALIZER;
         if ((eno = ::pthread_cond_init(cond_, &cond_attr)) != 0) {
-            log.error("fail pthread_cond_init[%d]", eno);
+            log.error("fail pthread_cond_init[", eno, "]");
             return false;
         }
         finally.dismiss();
@@ -84,7 +84,7 @@ class condition {
         if ((shm_.ref() <= 1) && cond_ != nullptr) {
             int eno;
             if ((eno = ::pthread_cond_destroy(cond_)) != 0) {
-                log.error("fail pthread_cond_destroy[%d]", eno);
+                log.error("fail pthread_cond_destroy[", eno, "]");
             }
         }
         shm_.release();
@@ -95,7 +95,7 @@ class condition {
         if ((shm_.ref() <= 1) && cond_ != nullptr) {
             int eno;
             if ((eno = ::pthread_cond_destroy(cond_)) != 0) {
-                log.error("fail pthread_cond_destroy[%d]", eno);
+                log.error("fail pthread_cond_destroy[", eno, "]");
             }
         }
         shm_.clear(); // Make sure the storage is cleaned up.
@@ -113,7 +113,7 @@ class condition {
         case invalid_value: {
                 int eno;
                 if ((eno = ::pthread_cond_wait(cond_, static_cast<pthread_mutex_t *>(mtx.native()))) != 0) {
-                    log.error("fail pthread_cond_wait[%d]", eno);
+                    log.error("fail pthread_cond_wait[", eno, "]");
                     return false;
                 }
             }
@@ -137,7 +137,7 @@ class condition {
         if (!valid()) return false;
         int eno;
         if ((eno = ::pthread_cond_signal(cond_)) != 0) {
-            log.error("fail pthread_cond_signal[%d]", eno);
+            log.error("fail pthread_cond_signal[", eno, "]");
             return false;
         }
         return true;
@@ -147,7 +147,7 @@ class condition {
         if (!valid()) return false;
         int eno;
         if ((eno = ::pthread_cond_broadcast(cond_)) != 0) {
-            log.error("fail pthread_cond_broadcast[%d]", eno);
+            log.error("fail pthread_cond_broadcast[", eno, "]");
             return false;
         }
         return true;
diff --git a/src/libipc/platform/posix/semaphore_impl.h b/src/libipc/platform/posix/semaphore_impl.h
@@ -37,7 +37,7 @@ class semaphore {
         LIBIPC_LOG();
         close();
         if (!shm_.acquire(name, 1)) {
-            log.error("[open_semaphore] fail shm.acquire: ", name, "");
+            log.error("[open_semaphore] fail shm.acquire: ", name);
             return false;
         }
         // POSIX semaphore names must start with "/" on some platforms (e.g., FreeBSD)
@@ -49,7 +49,7 @@ class semaphore {
         }
         h_ = ::sem_open(sem_name_.c_str(), O_CREAT, 0666, static_cast<unsigned>(count));
         if (h_ == SEM_FAILED) {
-            log.error("fail sem_open[%d]: ", errno, sem_name_.c_str(, ""));
+            log.error("fail sem_open[", errno, "]: ", sem_name_);
             return false;
         }
         return true;
@@ -59,13 +59,13 @@ class semaphore {
         LIBIPC_LOG();
         if (!valid()) return;
         if (::sem_close(h_) != 0) {
-            log.error("fail sem_close[%d]: ", errno, "");
+            log.error("fail sem_close[", errno, "]");
         }
         h_ = SEM_FAILED;
         if (!sem_name_.empty() && shm_.name() != nullptr) {
             if (shm_.release() <= 1) {
                 if (::sem_unlink(sem_name_.c_str()) != 0) {
-                    log.error("fail sem_unlink[%d]: ", errno, sem_name_.c_str(, ", name: %s"));
+                    log.error("fail sem_unlink[", errno, "]: ", sem_name_);
                 }
             }
         }
@@ -76,7 +76,7 @@ class semaphore {
         LIBIPC_LOG();
         if (valid()) {
             if (::sem_close(h_) != 0) {
-                log.error("fail sem_close[%d]: ", errno, "");
+                log.error("fail sem_close[", errno, "]");
             }
             h_ = SEM_FAILED;
         }
@@ -104,7 +104,7 @@ class semaphore {
         if (!valid()) return false;
         if (tm == invalid_value) {
             if (::sem_wait(h_) != 0) {
-                log.error("fail sem_wait[%d]: ", errno, "");
+                log.error("fail sem_wait[", errno, "]");
                 return false;
             }
         } else {
@@ -124,7 +124,7 @@ class semaphore {
         if (!valid()) return false;
         for (std::uint32_t i = 0; i < count; ++i) {
             if (::sem_post(h_) != 0) {
-                log.error("fail sem_post[%d]: ", errno, "");
+                log.error("fail sem_post[", errno, "]");
                 return false;
             }
         }
diff --git a/src/libipc/platform/win/mutex.h b/src/libipc/platform/win/mutex.h
@@ -40,7 +40,7 @@ class mutex {
         close();
         h_ = ::CreateMutex(detail::get_sa(), FALSE, detail::to_tchar(name).c_str());
         if (h_ == NULL) {
-            log.error("fail CreateMutex[%lu]: ", ::GetLastError(, ""), name);
+            log.error("fail CreateMutex[", static_cast<unsigned long>(::GetLastError()), "]: ", name);
             return false;
         }
         return true;
diff --git a/src/libipc/platform/win/semaphore.h b/src/libipc/platform/win/semaphore.h
@@ -39,7 +39,7 @@ class semaphore {
                                static_cast<LONG>(count), LONG_MAX, 
                                detail::to_tchar(name).c_str());
         if (h_ == NULL) {
-            log.error("fail CreateSemaphore[%lu]: ", ::GetLastError(, ""), name);
+            log.error("fail CreateSemaphore[", static_cast<unsigned long>(::GetLastError()), "]: ", name);
             return false;
         }
         return true;

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ class semaphore {`
`37`	`37`	`LIBIPC_LOG();`
`38`	`38`	`close();`
`39`	`39`	`if (!shm_.acquire(name, 1)) {`
`40`		`- log.error("[open_semaphore] fail shm.acquire: ", name, "");`
	`40`	`+ log.error("[open_semaphore] fail shm.acquire: ", name);`
`41`	`41`	`return false;`
`42`	`42`	`}`
`43`	`43`	`// POSIX semaphore names must start with "/" on some platforms (e.g., FreeBSD)`
`@@ -49,7 +49,7 @@ class semaphore {`
`49`	`49`	`}`
`50`	`50`	`h_ = ::sem_open(sem_name_.c_str(), O_CREAT, 0666, static_cast<unsigned>(count));`
`51`	`51`	`if (h_ == SEM_FAILED) {`
`52`		`- log.error("fail sem_open[%d]: ", errno, sem_name_.c_str(, ""));`
	`52`	`+ log.error("fail sem_open[", errno, "]: ", sem_name_);`
`53`	`53`	`return false;`
`54`	`54`	`}`
`55`	`55`	`return true;`
`@@ -59,13 +59,13 @@ class semaphore {`
`59`	`59`	`LIBIPC_LOG();`
`60`	`60`	`if (!valid()) return;`
`61`	`61`	`if (::sem_close(h_) != 0) {`
`62`		`- log.error("fail sem_close[%d]: ", errno, "");`
	`62`	`+ log.error("fail sem_close[", errno, "]");`
`63`	`63`	`}`
`64`	`64`	`h_ = SEM_FAILED;`
`65`	`65`	`if (!sem_name_.empty() && shm_.name() != nullptr) {`
`66`	`66`	`if (shm_.release() <= 1) {`
`67`	`67`	`if (::sem_unlink(sem_name_.c_str()) != 0) {`
`68`		`- log.error("fail sem_unlink[%d]: ", errno, sem_name_.c_str(, ", name: %s"));`
	`68`	`+ log.error("fail sem_unlink[", errno, "]: ", sem_name_);`
`69`	`69`	`}`
`70`	`70`	`}`
`71`	`71`	`}`
`@@ -76,7 +76,7 @@ class semaphore {`
`76`	`76`	`LIBIPC_LOG();`
`77`	`77`	`if (valid()) {`
`78`	`78`	`if (::sem_close(h_) != 0) {`
`79`		`- log.error("fail sem_close[%d]: ", errno, "");`
	`79`	`+ log.error("fail sem_close[", errno, "]");`
`80`	`80`	`}`
`81`	`81`	`h_ = SEM_FAILED;`
`82`	`82`	`}`
`@@ -104,7 +104,7 @@ class semaphore {`
`104`	`104`	`if (!valid()) return false;`
`105`	`105`	`if (tm == invalid_value) {`
`106`	`106`	`if (::sem_wait(h_) != 0) {`
`107`		`- log.error("fail sem_wait[%d]: ", errno, "");`
	`107`	`+ log.error("fail sem_wait[", errno, "]");`
`108`	`108`	`return false;`
`109`	`109`	`}`
`110`	`110`	`} else {`
`@@ -124,7 +124,7 @@ class semaphore {`
`124`	`124`	`if (!valid()) return false;`
`125`	`125`	`for (std::uint32_t i = 0; i < count; ++i) {`
`126`	`126`	`if (::sem_post(h_) != 0) {`
`127`		`- log.error("fail sem_post[%d]: ", errno, "");`
	`127`	`+ log.error("fail sem_post[", errno, "]");`
`128`	`128`	`return false;`
`129`	`129`	`}`
`130`	`130`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ class mutex {`
`40`	`40`	`close();`
`41`	`41`	`h_ = ::CreateMutex(detail::get_sa(), FALSE, detail::to_tchar(name).c_str());`
`42`	`42`	`if (h_ == NULL) {`
`43`		`- log.error("fail CreateMutex[%lu]: ", ::GetLastError(, ""), name);`
	`43`	`+ log.error("fail CreateMutex[", static_cast<unsigned long>(::GetLastError()), "]: ", name);`
`44`	`44`	`return false;`
`45`	`45`	`}`
`46`	`46`	`return true;`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ class semaphore {`
`39`	`39`	`static_cast<LONG>(count), LONG_MAX,`
`40`	`40`	`detail::to_tchar(name).c_str());`
`41`	`41`	`if (h_ == NULL) {`
`42`		`- log.error("fail CreateSemaphore[%lu]: ", ::GetLastError(, ""), name);`
	`42`	`+ log.error("fail CreateSemaphore[", static_cast<unsigned long>(::GetLastError()), "]: ", name);`
`43`	`43`	`return false;`
`44`	`44`	`}`
`45`	`45`	`return true;`