Skip to content

Commit 32c4634

Browse files
committed
actions/setup-go v2 is out of beta
1 parent a98aeb2 commit 32c4634

File tree

2 files changed

+3
-22
lines changed

2 files changed

+3
-22
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
runs-on: ${{ matrix.platform }}
1010
steps:
1111
- name: Install Go
12-
uses: actions/setup-go@v1
12+
uses: actions/setup-go@v2
1313
with:
1414
go-version: ${{ matrix.go-version }}
1515
- name: Checkout code
@@ -24,7 +24,7 @@ jobs:
2424
runs-on: ubuntu-latest
2525
steps:
2626
- name: Install Go
27-
uses: actions/setup-go@v1
27+
uses: actions/setup-go@v2
2828
with:
2929
go-version: 1.14.x
3030
- name: Checkout code

README.md

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
runs-on: ${{ matrix.platform }}
1919
steps:
2020
- name: Install Go
21-
uses: actions/setup-go@v1
21+
uses: actions/setup-go@v2
2222
with:
2323
go-version: ${{ matrix.go-version }}
2424
- name: Checkout code
@@ -171,25 +171,6 @@ jobs:
171171

172172
## Known bugs
173173

174-
* https://github.com/actions/setup-go/issues/14
175-
176-
The `setup-go` action doesn't set `PATH`, so currently it's not possible to `go
177-
install` a program and run it directly. Until that's fixed, consider absolute
178-
paths like `$(go env GOPATH)/bin/program`.
179-
180-
A workaround is to use a built-in [workflow command](https://help.github.com/en/actions/reference/workflow-commands-for-github-actions#adding-a-system-path)
181-
to add `GOBIN` to the system's `PATH`. Note that `shell: bash` is supported on
182-
all platforms:
183-
184-
```yaml
185-
- name: Add GOBIN to PATH
186-
run: echo "::add-path::$(go env GOPATH)/bin"
187-
shell: bash
188-
```
189-
190-
Note that the upcoming `actions/setup-go@v2` fixes this issue, but is still in
191-
beta as of April 2020.
192-
193174
* https://github.community/t5/GitHub-Actions/git-config-core-autocrlf-should-default-to-false/m-p/30445 and https://github.com/actions/checkout/issues/135
194175

195176
`git config core.autocrlf` defaults to true, so be careful about CRLF endings in

0 commit comments

Comments
 (0)