Use copy for GUID (with copy trait) (#5)

Author: mveril

plugin/src/lib.rs

@@ -132,7 +132,7 @@ impl WSLPluginV1 for Plugin {
 }
 
 impl Plugin {
-    fn log_os_release(&self, session: &WSLSessionInformation, distro_id: Option<&GUID>) {
+    fn log_os_release(&self, session: &WSLSessionInformation, distro_id: Option<GUID>) {
         let args: [&str; 2] = ["/bin/cat", "/etc/os-release"];
         let tcp_stream: std::result::Result<std::net::TcpStream, api::Error> = match distro_id {
             Some(dist_id) => self

wslplugins-rs/src/api/api_v1.rs

@@ -210,7 +210,7 @@ impl ApiV1<'_> {
     pub fn execute_binary_in_distribution<P: AsRef<Utf8UnixPath>>(
         &self,
         session: &WSLSessionInformation,
-        distribution_id: &GUID,
+        distribution_id: GUID,
         path: P,
         args: &[&str],
     ) -> Result<TcpStream> {
@@ -235,7 +235,7 @@ impl ApiV1<'_> {
         let stream = unsafe {
             self.0.ExecuteBinaryInDistribution.unwrap_unchecked()(
                 session.id(),
-                distribution_id,
+                &distribution_id,
                 path_ptr,
                 args_ptr,
                 socket.as_mut_ptr(),

wslplugins-rs/src/core_distribution_information.rs

@@ -22,8 +22,8 @@ pub trait CoreDistributionInformation {
     /// The ID is guaranteed to remain the same across reboots.
     ///
     /// # Returns
-    /// A reference to the [GUID] representing the distribution's unique identifier.
-    fn id(&self) -> &GUID;
+    /// The [GUID] representing the distribution's unique identifier.
+    fn id(&self) -> GUID;
 
     /// Retrieves the name of the distribution.
     ///

wslplugins-rs/src/distribution_information.rs

@@ -79,8 +79,8 @@ impl CoreDistributionInformation for DistributionInformation<'_> {
     ///
     /// # Returns
     /// A reference to the [GUID] representing the distribution's unique identifier.
-    fn id(&self) -> &GUID {
-        &self.0.Id
+    fn id(&self) -> GUID {
+        self.0.Id
     }
 
     /// Retrieves the name of the distribution.

wslplugins-rs/src/offline_distribution_information.rs

@@ -39,8 +39,8 @@ impl<'a> OfflineDistributionInformation<'a> {
 
 impl CoreDistributionInformation for OfflineDistributionInformation<'_> {
     /// Retrieves the [GUID] of the offline distribution.
-    fn id(&self) -> &GUID {
-        &self.0.Id
+    fn id(&self) -> GUID {
+        self.0.Id
     }
 
     /// Retrieves the name of the offline distribution as an [OsString].