Merge pull request #16 from mwakaba2/pr-update-time

Fix: display notifications for set minimum execution time > 60

Author: mwakaba2

src/index.ts

@@ -89,7 +89,8 @@ const extension: JupyterFrontEndPlugin<void> = {
               metadata
             );
             const diff = new Date(<any>cellEndTime - <any>cellStartTime);
-            if (diff.getSeconds() >= minimumCellExecutionTime) {
+            const diffSeconds = Math.floor(diff.getTime() / 1000);
+            if (diffSeconds >= minimumCellExecutionTime) {
               const cellDuration = diff.toISOString().substr(11, 8);
               const cellNumber =
                 cellNumberType === 'cell_index'

tutorial/notebook_notification_py3_demo.ipynb

@@ -5,11 +5,11 @@
    "execution_count": 1,
    "metadata": {
     "execution": {
-     "iopub.execute_input": "2021-05-16T01:17:43.398697Z",
-     "iopub.status.busy": "2021-05-16T01:17:43.398438Z",
-     "iopub.status.idle": "2021-05-16T01:17:43.406473Z",
-     "shell.execute_reply": "2021-05-16T01:17:43.405574Z",
-     "shell.execute_reply.started": "2021-05-16T01:17:43.398631Z"
+     "iopub.execute_input": "2021-06-18T16:13:11.410779Z",
+     "iopub.status.busy": "2021-06-18T16:13:11.410414Z",
+     "iopub.status.idle": "2021-06-18T16:13:11.423394Z",
+     "shell.execute_reply": "2021-06-18T16:13:11.422189Z",
+     "shell.execute_reply.started": "2021-06-18T16:13:11.410668Z"
     },
     "tags": []
    },
@@ -28,14 +28,40 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 2,
+   "execution_count": 5,
+   "metadata": {
+    "execution": {
+     "iopub.execute_input": "2021-06-18T16:23:33.407046Z",
+     "iopub.status.busy": "2021-06-18T16:23:33.406829Z",
+     "iopub.status.idle": "2021-06-18T16:23:36.529019Z",
+     "shell.execute_reply": "2021-06-18T16:23:36.528045Z",
+     "shell.execute_reply.started": "2021-06-18T16:23:33.407023Z"
+    }
+   },
+   "outputs": [
+    {
+     "name": "stdout",
+     "output_type": "stream",
+     "text": [
+      "hello!\n"
+     ]
+    }
+   ],
+   "source": [
+    "!sleep 3\n",
+    "print(\"hello!\")"
+   ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": 6,
    "metadata": {
     "execution": {
-     "iopub.execute_input": "2021-05-16T01:17:43.408122Z",
-     "iopub.status.busy": "2021-05-16T01:17:43.407871Z",
-     "iopub.status.idle": "2021-05-16T01:17:46.537467Z",
-     "shell.execute_reply": "2021-05-16T01:17:46.536828Z",
-     "shell.execute_reply.started": "2021-05-16T01:17:43.408099Z"
+     "iopub.execute_input": "2021-06-18T16:23:46.212426Z",
+     "iopub.status.busy": "2021-06-18T16:23:46.212217Z",
+     "iopub.status.idle": "2021-06-18T16:24:52.337429Z",
+     "shell.execute_reply": "2021-06-18T16:24:52.336762Z",
+     "shell.execute_reply.started": "2021-06-18T16:23:46.212401Z"
     },
     "tags": []
    },
@@ -49,7 +75,7 @@
     }
    ],
    "source": [
-    "!sleep 3\n",
+    "!sleep 66\n",
     "print(\"hello world!\")"
    ]
   },