Use copies of style dictionaries in tests

Author: mwcraig

src/astro_image_display_api/dummy_viewer.py

@@ -17,7 +17,7 @@
 @dataclass
 class CatalogInfo:
     """
-    A named tuple to hold information about a catalog.
+    Class to hold information about a catalog.
     """
     style: dict[str, Any] = field(default_factory=dict)
     data: Table | None = None
@@ -153,7 +153,7 @@ def get_catalog_style(self, catalog_label=None) -> dict[str, Any]:
         """
         catalog_label = self._resolve_catalog_label(catalog_label)
 
-        style = self._catalogs[catalog_label].style
+        style = self._catalogs[catalog_label].style.copy()
         style["catalog_label"] = catalog_label
         return style
 
@@ -290,7 +290,7 @@ def save(self, filename: str | os.PathLike, overwrite: bool = False) -> None:
 
     # Marker-related methods
     def load_catalog(self, table: Table, x_colname: str = 'x', y_colname: str = 'y',
-                    skycoord_colname: str = 'coord', use_skycoord: bool = True,
+                    skycoord_colname: str = 'coord', use_skycoord: bool = False,
                     catalog_label: str | None = None,
                     catalog_style: dict | None = None) -> None:
         try:

src/astro_image_display_api/interface_definition.py

@@ -78,7 +78,7 @@ def load_catalog(self, table: Table, x_colname: str = 'x', y_colname: str = 'y',
                     catalog_label: str | None = None,
                     catalog_style: dict | None = None) -> None:
         """
-        Add markers to the viewer at positions given by a catalog.
+        Add catalog entries to the viewer at positions given by the catalog.
 
         Parameters
         ----------

src/astro_image_display_api/widget_api_test.py

@@ -157,7 +157,7 @@ def test_set_get_catalog_style_no_labels(self, catalog):
         self.image.load_catalog(catalog)
         # Check that setting a marker style works
         marker_settings = dict(color='red', shape='x', size=10)
-        self.image.set_catalog_style(**marker_settings)
+        self.image.set_catalog_style(**marker_settings.copy())
 
         retrieved_style = self.image.get_catalog_style()
         # Check that the marker style is set correctly
@@ -173,7 +173,7 @@ def test_set_get_catalog_style_with_single_label(self, catalog):
         self.image.load_catalog(catalog, catalog_label='test1')
         set_style_input = dict(catalog_label='test1', color='blue',
                                      shape='square', size=5)
-        self.image.set_catalog_style(**set_style_input)
+        self.image.set_catalog_style(**set_style_input.copy())
         retrieved_style = self.image.get_catalog_style()
 
         assert set_style_input == retrieved_style
@@ -367,9 +367,12 @@ def test_load_catalog_with_style_sets_style(self, catalog):
         # for that catalog.
         style = dict(color='blue', shape='x', size=10)
         self.image.load_catalog(catalog, catalog_label='test1',
-                                catalog_style=style)
+                                catalog_style=style.copy())
 
         retrieved_style = self.image.get_catalog_style(catalog_label='test1')
+
+        # Add catalog_label to the style for comparison
+        style['catalog_label'] = 'test1'
         assert retrieved_style == style
 
     def test_remove_catalog(self):