chore: lint

Signed-off-by: Innei <tukon479@gmail.com>

Author: Innei

apps/core/package.json

@@ -162,4 +162,4 @@
     "vite-tsconfig-paths": "5.1.4",
     "vitest": "1.5.2"
   }
-}
+}

apps/core/src/app.controller.ts

@@ -10,7 +10,6 @@ import { Auth } from '~/common/decorators/auth.decorator'
 import { InjectModel } from '~/transformers/model.transformer'
 import dayjs from 'dayjs'
 import PKG from '../package.json'
-import { DEMO_MODE } from './app.config'
 import { HttpCache } from './common/decorators/cache.decorator'
 import { HTTPDecorators } from './common/decorators/http.decorator'
 import { IpLocation, IpRecord } from './common/decorators/ip.decorator'

apps/core/src/common/interceptors/idempotence.interceptor.ts

@@ -101,7 +101,9 @@ export class IdempotenceInterceptor implements NestInterceptor {
       const resultValue: '0' | '1' | null = (await redis.get(
         idempotenceKey,
       )) as any
-      if (resultValue !== null) {
+      if (resultValue === null) {
+        await redis.set(idempotenceKey, '0', 'EX', expired)
+      } else {
         if (errorHandler) {
           return await errorHandler(request)
         }
@@ -111,8 +113,6 @@ export class IdempotenceInterceptor implements NestInterceptor {
           0: pendingMessage,
         }[resultValue]
         throw new ConflictException(message)
-      } else {
-        await redis.set(idempotenceKey, '0', 'EX', expired)
       }
     }
     return next.handle().pipe(
@@ -141,7 +141,7 @@ export class IdempotenceInterceptor implements NestInterceptor {
       const ip = getIp(req)
 
       if (!ua && !ip) {
-        return undefined
+        return
       }
       Object.assign(obj, { ua, ip })
     }

apps/core/src/common/interceptors/response.interceptor.ts

@@ -44,7 +44,7 @@ export class ResponseInterceptor<T> implements NestInterceptor<T, Response<T>> {
 
     return next.handle().pipe(
       map((data) => {
-        if (typeof data === 'undefined') {
+        if (data === undefined) {
           context.switchToHttp().getResponse().status(204)
           return data
         }

apps/core/src/constants/path.constant.ts

@@ -18,9 +18,9 @@ export const LOG_DIR = join(DATA_DIR, 'log')
 export const STATIC_FILE_DIR = join(DATA_DIR, 'static')
 export const STATIC_FILE_TRASH_DIR = join(TEMP_DIR, 'trash')
 
-export const BACKUP_DIR = !isDev
-  ? join(DATA_DIR, 'backup')
-  : join(TEMP_DIR, 'backup')
+export const BACKUP_DIR = isDev
+  ? join(TEMP_DIR, 'backup')
+  : join(DATA_DIR, 'backup')
 
 // 生产环境直接打包到 目录的 admin 下
 export const LOCAL_ADMIN_ASSET_PATH = isDev

apps/core/src/global/consola.global.ts

@@ -3,12 +3,12 @@ import { LOG_DIR } from '~/constants/path.constant'
 import { isTest } from './env.global'
 
 const logger = createLogger({
-  writeToFile: !isTest
-    ? {
+  writeToFile: isTest
+    ? undefined
+    : {
         loggerDir: LOG_DIR,
         errWriteToStdout: true,
-      }
-    : undefined,
+      },
 })
 Logger.setLoggerInstance(logger)
 if (!isTest) {

apps/core/src/modules/activity/activity.controller.ts

@@ -196,9 +196,7 @@ export class ActivityController {
     for (const item of like.data) {
       const likeData = pick(item, 'created', 'id') as any
 
-      if (!item.ref) {
-        likeData.title = '已删除的内容'
-      } else {
+      if (item.ref) {
         if ('nid' in item.ref) {
           likeData.type = CollectionRefTypes.Note
           likeData.nid = item.ref.nid
@@ -207,6 +205,8 @@ export class ActivityController {
           likeData.slug = item.ref.slug
         }
         likeData.title = item.ref.title
+      } else {
+        likeData.title = '已删除的内容'
       }
 
       transformedLike.push(likeData)

apps/core/src/modules/activity/dtos/activity.dto.ts

@@ -4,7 +4,7 @@ import { IsEnum, IsInt, IsNumber, IsOptional } from 'class-validator'
 import { Activity } from '../activity.constant'
 
 const TransformEnum = () =>
-  Transform(({ value }) => (typeof value === 'undefined' ? value : +value))
+  Transform(({ value }) => (value === undefined ? value : +value))
 
 export class ActivityTypeParamsDto {
   @IsEnum(Activity)

apps/core/src/modules/aggregate/aggregate.controller.ts

@@ -48,16 +48,16 @@ export class AggregateController {
       this.configsService.get('url'),
       this.configsService.get('seo'),
       this.noteService.getLatestNoteId(),
-      !theme
-        ? Promise.resolve()
-        : this.snippetService
+      theme
+        ? this.snippetService
             .getCachedSnippet('theme', theme, 'public')
             .then((cached) => {
               if (cached) {
                 return JSON.safeParse(cached) || cached
               }
               return this.snippetService.getPublicSnippetByName(theme, 'theme')
-            }),
+            })
+        : Promise.resolve(),
     ])
     const [user, categories, pageMeta, url, seo, latestNoteId, themeConfig] =
       tasks.map((t) => {

apps/core/src/modules/aggregate/aggregate.service.ts

@@ -97,18 +97,18 @@ export class AggregateService {
     const [notes, posts, says, recently] = await Promise.all([
       this.findTop(
         this.noteService.model,
-        !isAuthenticated
-          ? {
+        isAuthenticated
+          ? {}
+          : {
               isPublished: true,
               password: undefined,
-            }
-          : {},
+            },
         size,
       ).lean({ getters: true }),
 
       this.findTop(
         this.postService.model,
-        !isAuthenticated ? { isPublished: true } : {},
+        isAuthenticated ? {} : { isPublished: true },
         size,
       )
         .populate('categoryId')