devops: have generate random minio credentials (#283)

Author: mxschmitt

.github/workflows/nodejs.yml

@@ -31,6 +31,8 @@ jobs:
     - name: Generate K8 files
       run: |
         version="$(bash .github/workflows/determine_docker_image_tag.sh)"
+        export MINIO_ROOT_USER="minioadmin"
+        export MINIO_ROOT_PASSWORD=$(openssl rand -base64 32)
         bash k8/generate.sh $version
       env:
         WORKER_COUNT: 1

README.md

@@ -15,6 +15,8 @@ git clone https://github.com/mxschmitt/try-playwright.git
 openssl req -x509 -nodes -days 730 -newkey rsa:2048 -keyout tls.key -out tls.crt -subj "/CN=try.playwright.tech/O=try.playwright.tech"
 kubectl create secret tls try-playwright-cf-tls-cert --key=tls.key --cert=tls.crt
 cd try-playwright
+export MINIO_ROOT_USER="admin"
+export MINIO_ROOT_PASSWORD=$(openssl rand -base64 32)
 bash k8/generate.sh
 kubectl apply -f k8/
 ```

e2e/playwright.config.ts

@@ -18,7 +18,7 @@ const config = defineConfig({
   testDir: path.join(__dirname, 'tests'),
   forbidOnly: !!process.env.CI,
   retries: process.env.CI ? 2 : undefined,
-  reporter: 'html',
+  reporter: [['list'], ['html']],
   workers: 1,
   use: {
     trace: process.env.CI ? 'on-all-retries' : undefined,

k8/file-deployment.yaml.tpl

@@ -22,9 +22,9 @@ spec:
             - name: MINIO_ENDPOINT
               value: minio:9000
             - name: MINIO_ACCESS_KEY
-              value: "minio"
+              value: "${MINIO_ROOT_USER}"
             - name: MINIO_SECRET_KEY
-              value: "R9gGSFb4QkZH8LzzS8SECsG66JNX"
+              value: "${MINIO_ROOT_PASSWORD}"
             - name: FILE_SERVICE_SENTRY_DSN
               value: https://[email protected]/5479804
           image: ghcr.io/mxschmitt/try-playwright/file-service:${DOCKER_TAG}

k8/generate.sh

@@ -5,6 +5,10 @@ set -e
 export DOCKER_TAG="${1:-latest}"
 export WORKER_COUNT="${WORKER_COUNT:-2}"
 
+# Validate required environment variables
+: "${MINIO_ROOT_USER:?Need to set MINIO_ROOT_USER}"
+: "${MINIO_ROOT_PASSWORD:?Need to set MINIO_ROOT_PASSWORD}"
+
 for file_path in k8/*.yaml.tpl; do
     filename="$(basename ${file_path})"
     outname="k8/generated-${filename/%.yaml.tpl/.yaml}"

k8/minio-deployment.yaml k8/minio-deployment.yaml.tplk8/minio-deployment.yaml renamed to k8/minio-deployment.yaml.tpl

@@ -24,7 +24,7 @@ spec:
           name: minio
           env:
             - name: MINIO_ROOT_USER
-              value: "minio"
+              value: "${MINIO_ROOT_USER}"
             - name: MINIO_ROOT_PASSWORD
-              value: "R9gGSFb4QkZH8LzzS8SECsG66JNX"
+              value: "${MINIO_ROOT_PASSWORD}"
       restartPolicy: Always