[ISSUE #2618]🐛Fix PopMessageRequestHeader#is_timeout_too_much attempt to subtract with overflow🔥 (#2621)

mxsm · web-flow · commit 73b94ce82377 · 2025-02-28T21:41:06.000+08:00
diff --git a/rocketmq-remoting/src/protocol/header/pop_message_request_header.rs b/rocketmq-remoting/src/protocol/header/pop_message_request_header.rs
@@ -54,7 +54,7 @@ pub struct PopMessageRequestHeader {
 
 impl PopMessageRequestHeader {
     pub fn is_timeout_too_much(&self) -> bool {
-        get_current_millis() - self.born_time - self.poll_time > 500
+        get_current_millis() as i64 - self.born_time as i64 - self.poll_time as i64 > 500
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ pub struct PopMessageRequestHeader {`
`54`	`54`
`55`	`55`	`impl PopMessageRequestHeader {`
`56`	`56`	`pub fn is_timeout_too_much(&self) -> bool {`
`57`		`- get_current_millis() - self.born_time - self.poll_time > 500`
	`57`	`+ get_current_millis() as i64 - self.born_time as i64 - self.poll_time as i64 > 500`
`58`	`58`	`}`
`59`	`59`	`}`
`60`	`60`