Skip to content

Commit 95022d6

Browse files
authored
[ISSUE #4023]♻️Refactor: Optimize queue data collection and simplify broker ID retrieval logic (#4024)
1 parent 42367c5 commit 95022d6

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

rocketmq-namesrv/src/route/route_info_manager.rs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,10 @@ impl RouteInfoManager {
438438
// Acquire read lock
439439
let lock = self.lock.read();
440440
if let Some(queue_data_map) = self.topic_queue_table.get(topic) {
441-
topic_route_data.queue_datas = queue_data_map.values().cloned().collect();
441+
topic_route_data
442+
.queue_datas
443+
.extend(queue_data_map.values().cloned().collect::<Vec<_>>());
444+
442445
found_queue_data = true;
443446

444447
for broker_name in queue_data_map.keys() {
@@ -511,9 +514,8 @@ impl RouteInfoManager {
511514
for queue_data in &topic_route_data.queue_datas {
512515
if queue_data.broker_name() == broker_data.broker_name() {
513516
if !PermName::is_writeable(queue_data.perm()) {
514-
if let Some(min_broker_id) =
515-
broker_data.broker_addrs().keys().cloned().min()
516-
{
517+
if let Some(min_broker_id) = broker_data.broker_addrs().keys().min() {
518+
let min_broker_id = *min_broker_id;
517519
if let Some(acting_master_addr) =
518520
broker_data.broker_addrs_mut().remove(&min_broker_id)
519521
{

0 commit comments

Comments
 (0)