refactor: instanceof comparisons, dont log stack

Author: hugocortes

lib/Auth/index.js

@@ -149,6 +149,7 @@ class Auth {
    * @param {String}  opts.cache.key
    * @param {String}  opts.cache.action
    * @param {Boolean} opts.cache.onNotFound
+   * @param {Object}  [opts.error = {}]     Error options
    * @param {Number}  retry                 Allow retries in case of expired token
    *
    * @returns {Promise<{} | Array<{}>>}
@@ -166,7 +167,8 @@ class Auth {
         isPublic: false,
         cache: false,
         timeout: 60000,
-        deadline: 90000
+        deadline: 90000,
+        error: {}
       },
       opts
     );
@@ -243,7 +245,10 @@ class Auth {
         opts.cache.action === this.cache.actions.get &&
         opts.cache.onNotFound &&
         error.status === 404 &&
-        error.typeof !== CoreError.CachedNotFound
+        !(
+          error instanceof CoreError &&
+          error.typeof.name === CoreError.CachedNotFound.name
+        )
       ) {
         await this.executeCacheOp({
           value: false,
@@ -255,7 +260,10 @@ class Auth {
       if (
         !opts.isPublic &&
         error.status === 401 &&
-        error.typeof !== CoreError.MaxAuthenticatedRequestsReached
+        !(
+          error instanceof CoreError &&
+          error.typeof.name === CoreError.MaxAuthenticatedRequestsReached.name
+        )
       ) {
         this.access.failed = true;
         return this.send(service, method, url, opts, ++retry);
@@ -267,7 +275,8 @@ class Auth {
         service,
         method,
         this.timeDelta(begin),
-        opts.query
+        opts.query,
+        opts.error
       );
     }
   }
@@ -277,28 +286,37 @@ class Auth {
    *
    * @private
    *
-   * @param {typeof Error} error   Error returned
-   * @param {String}       url     Endpoint
-   * @param {String}       service Core service requested
-   * @param {String}       method  REST method used
-   * @param {Number}       tDelta  Request time in ms
-   * @param {Object}       query   The query sent
+   * @param {typeof Error} error             Error returned
+   * @param {String}       url               Endpoint
+   * @param {String}       service           Core service requested
+   * @param {String}       method            REST method used
+   * @param {Number}       tDelta            Request time in ms
+   * @param {Object}       query             The query sent
+   * @param {Object}       opts              Additional options
+   * @param {Boolean}      [opts.mute=false] Whether to mute the error log
    *
    * @returns {CoreError}
    */
-  getError(error, url, service, method, tDelta, query) {
+  getError(error, url, service, method, tDelta, query, opts = {}) {
+    opts = { mute: false, ...opts };
+
     const errorText =
       !!error.response && !!error.response.text
         ? error.response.text
+        : error instanceof CoreError && (error.isInternal || error.isCache)
+        ? error.typeof.name
         : error.stack;
-    this.log(
-      `${service} ${method}, code: ${
-        error.status
-      }, t: ${tDelta} ms -> url: ${url}, query: ${JSON.stringify(
-        query || {}
-      )} -> error response ${errorText}`,
-      'error'
-    );
+
+    if (!opts.mute) {
+      this.log(
+        `${service} ${method}, code: ${
+          error.isCache ? 'CACHED' : error.status
+        }, t: ${tDelta} ms -> url: ${url}, query: ${JSON.stringify(
+          query || {}
+        )} -> error response ${errorText}`,
+        'error'
+      );
+    }
 
     if (error instanceof CoreError) {
       return error;