Skip to content

Commit 01fb095

Browse files
committed
Need to use our own jars for optional build dependencies
1 parent 05cb7f8 commit 01fb095

File tree

10 files changed

+15
-55
lines changed

10 files changed

+15
-55
lines changed

eclipse/org.mybatis.generator.core/META-INF/MANIFEST.MF

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,3 @@ Export-Package: org.mybatis.generator.ant,
4545
org.mybatis.generator.runtime.kotlin,
4646
org.mybatis.generator.runtime.kotlin.elements
4747
Automatic-Module-Name: org.mybatis.generator.core
48-
Import-Package: org.apache.commons.logging;version="1.2.0";resolution:=optional,
49-
org.apache.tools.ant;version="1.10.10";resolution:=optional,
50-
org.apache.tools.ant.types;version="1.10.10";resolution:=optional,
51-
org.slf4j;version="1.7.30";resolution:=optional,
52-
org.slf4j.spi;version="1.7.30";resolution:=optional

eclipse/org.mybatis.generator.core/build.properties

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,7 @@ src.includes = LICENSE,\
2626
NOTICE\
2727
2828
customBuildCallbacks=customBuildCallbacks.xml
29-
jars.extra.classpath = lib/log4j-api-2.19.0.jar
29+
jars.extra.classpath = lib/log4j-api-2.19.0.jar,\
30+
lib/slf4j-api-2.0.6.jar,\
31+
lib/commons-logging-1.2.jar,\
32+
lib/ant-1.10.13.jar
Binary file not shown.
Binary file not shown.
Binary file not shown.

eclipse/org.mybatis.generator.eclipse.ui/META-INF/MANIFEST.MF

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,4 @@ Export-Package: org.mybatis.generator.eclipse.ui,
3030
org.mybatis.generator.eclipse.ui.launcher,
3131
org.mybatis.generator.eclipse.ui.launcher.tabs,
3232
org.mybatis.generator.eclipse.ui.wizards
33-
Import-Package: org.apache.commons.logging;version="1.2.0";resolution:=optional,
34-
org.slf4j;version="1.7.30";resolution:=optional,
35-
org.slf4j.spi;version="1.7.30";resolution:=optional
3633
Automatic-Module-Name: org.mybatis.generator.eclipse.ui

eclipse/org.mybatis.generator.eclipse.ui/antsrc/org/mybatis/generator/eclipse/ui/ant/GeneratorAntTask.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@
4040
import org.mybatis.generator.eclipse.core.callback.EclipseProgressCallback;
4141
import org.mybatis.generator.eclipse.core.callback.EclipseShellCallback;
4242
import org.mybatis.generator.eclipse.ui.ant.logging.AntLogFactory;
43-
import org.mybatis.generator.eclipse.ui.ant.logging.LogException;
4443
import org.mybatis.generator.exception.InvalidConfigurationException;
4544
import org.mybatis.generator.exception.XMLParserException;
4645
import org.mybatis.generator.internal.util.StringUtility;
46+
import org.mybatis.generator.logging.LogException;
4747
import org.mybatis.generator.logging.LogFactory;
4848

4949
/**

eclipse/org.mybatis.generator.eclipse.ui/antsrc/org/mybatis/generator/eclipse/ui/ant/logging/AntLogFactory.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,13 @@
2020

2121
import org.mybatis.generator.eclipse.ui.ant.logging.commons.JakartaCommonsLoggingLogFactory;
2222
import org.mybatis.generator.eclipse.ui.ant.logging.log4j2.Log4j2LoggingLogFactory;
23-
import org.mybatis.generator.eclipse.ui.ant.logging.slf4j.Slf4jLoggingLogFactory;
23+
import org.mybatis.generator.eclipse.ui.launcher.tabs.LoggingButtonData;
2424
import org.mybatis.generator.logging.AbstractLogFactory;
2525
import org.mybatis.generator.logging.Log;
26+
import org.mybatis.generator.logging.LogException;
2627
import org.mybatis.generator.logging.jdk14.Jdk14LoggingLogFactory;
2728
import org.mybatis.generator.logging.nologging.NoLoggingLogFactory;
29+
import org.mybatis.generator.logging.slf4j.Slf4jLoggingLogFactory;
2830

2931
/**
3032
* Factory for creating loggers
@@ -39,13 +41,13 @@ public AntLogFactory(String loggingImplementation) throws LogException {
3941
if (loggingImplementation == null || loggingImplementation.length() == 0) {
4042
calculateDefaultImplementation();
4143
} else {
42-
if ("SLF4J".equals(loggingImplementation)) { //$NON-NLS-1$
44+
if (LoggingButtonData.SLF4J.name().equals(loggingImplementation)) {
4345
setImplementation(new Slf4jLoggingLogFactory());
44-
} else if ("COMMONS_LOGGING".equals(loggingImplementation)) { //$NON-NLS-1$
46+
} else if (LoggingButtonData.COMMONS_LOGGING.name().equals(loggingImplementation)) {
4547
setImplementation(new JakartaCommonsLoggingLogFactory());
46-
} else if ("LOG4J2".equals(loggingImplementation)) { //$NON-NLS-1$
48+
} else if (LoggingButtonData.LOG4J2.name().equals(loggingImplementation)) {
4749
setImplementation(new Log4j2LoggingLogFactory());
48-
} else if ("JDK".equals(loggingImplementation)) { //$NON-NLS-1$
50+
} else if (LoggingButtonData.JDK.name().equals(loggingImplementation)) {
4951
setImplementation(new Jdk14LoggingLogFactory());
5052
} else {
5153
setImplementation(new NoLoggingLogFactory());

eclipse/org.mybatis.generator.eclipse.ui/antsrc/org/mybatis/generator/eclipse/ui/ant/logging/LogException.java

Lines changed: 0 additions & 39 deletions
This file was deleted.

eclipse/org.mybatis.generator.eclipse.ui/build.properties

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,5 +32,7 @@ src.includes = LICENSE,\
3232
NOTICE,\
3333
icons/
3434
source.lib/antsupport.jar = antsrc/
35-
jars.extra.classpath = platform:/plugin/org.mybatis.generator.core/lib/log4j-api-2.19.0.jar
35+
jars.extra.classpath = platform:/plugin/org.mybatis.generator.core/lib/log4j-api-2.19.0.jar,\
36+
platform:/plugin/org.mybatis.generator.core/lib/slf4j-api-2.0.6.jar,\
37+
platform:/plugin/org.mybatis.generator.core/lib/commons-logging-1.2.jar
3638

0 commit comments

Comments
 (0)