http://code.google.com/p/mybatis/issues/detail?id=771 : Enable setting logger impl in mybatis-config.xml

Author: emacarron

src/main/java/org/apache/ibatis/builder/xml/XMLConfigBuilder.java

@@ -220,6 +220,7 @@ private void settingsElement(XNode context) throws Exception {
       configuration.setLazyLoadTriggerMethods(stringSetValueOf(props.getProperty("lazyLoadTriggerMethods"), "equals,clone,hashCode,toString"));
       configuration.setDefaultScriptingLanguage(resolveClass(props.getProperty("defaultScriptingLanguage")));
       configuration.setLogPrefix(props.getProperty("logPrefix"));
+      configuration.setLogImpl(resolveClass(props.getProperty("logImpl")));
       configuration.setCallSettersOnNulls(booleanValueOf(props.getProperty("callSettersOnNulls"), false));
     }
   }

src/main/java/org/apache/ibatis/session/Configuration.java

@@ -53,6 +53,8 @@
 import org.apache.ibatis.executor.statement.RoutingStatementHandler;
 import org.apache.ibatis.executor.statement.StatementHandler;
 import org.apache.ibatis.io.ResolverUtil;
+import org.apache.ibatis.logging.Log;
+import org.apache.ibatis.logging.LogFactory;
 import org.apache.ibatis.mapping.BoundSql;
 import org.apache.ibatis.mapping.Environment;
 import org.apache.ibatis.mapping.MappedStatement;
@@ -92,6 +94,7 @@ public class Configuration {
   protected boolean cacheEnabled = true;
   protected boolean callSettersOnNulls = false;
   protected String logPrefix;
+  protected Class <? extends Log> logImpl;
   protected LocalCacheScope localCacheScope = LocalCacheScope.SESSION;
   protected JdbcType jdbcTypeForNull = JdbcType.OTHER;
   protected Set<String> lazyLoadTriggerMethods = new HashSet<String>(Arrays.asList(new String[] { "equals", "clone", "hashCode", "toString" }));
@@ -158,6 +161,13 @@ public Configuration() {
     typeAliasRegistry.registerAlias("XML", XMLLanguageDriver.class.getName());
     typeAliasRegistry.registerAlias("RAW", RawLanguageDriver.class.getName());
 
+    typeAliasRegistry.registerAlias("SLF4J", org.apache.ibatis.logging.slf4j.Slf4jImpl.class.getName());
+    typeAliasRegistry.registerAlias("COMMONS_LOGGING", org.apache.ibatis.logging.commons.JakartaCommonsLoggingImpl.class.getName());
+    typeAliasRegistry.registerAlias("LOG4J", org.apache.ibatis.logging.log4j.Log4jImpl.class.getName());
+    typeAliasRegistry.registerAlias("JDK_LOGGING", org.apache.ibatis.logging.jdk14.Jdk14LoggingImpl.class.getName());
+    typeAliasRegistry.registerAlias("STDOUT_LOGGING", org.apache.ibatis.logging.stdout.StdOutImpl.class.getName());
+    typeAliasRegistry.registerAlias("NO_LOGGING", org.apache.ibatis.logging.nologging.NoLoggingImpl.class.getName());
+    
     languageRegistry.setDefaultDriverClass(XMLLanguageDriver.class);
     languageRegistry.register(RawLanguageDriver.class);
   }
@@ -170,6 +180,16 @@ public void setLogPrefix(String logPrefix) {
     this.logPrefix = logPrefix;
   }
 
+  public Class<? extends Log> getLogImpl() {
+    return logImpl;
+  }
+
+  @SuppressWarnings("unchecked")
+  public void setLogImpl(Class<?> logImpl) {
+    this.logImpl = (Class<? extends Log>) logImpl;
+    LogFactory.useCustomLogging(this.logImpl);
+  }
+
   public boolean isCallSettersOnNulls() {
     return callSettersOnNulls;
   }

src/test/java/org/apache/ibatis/logging/LogFactoryTest.java

@@ -17,12 +17,16 @@
 
 import static org.junit.Assert.assertEquals;
 
+import java.io.Reader;
+
+import org.apache.ibatis.io.Resources;
 import org.apache.ibatis.logging.commons.JakartaCommonsLoggingImpl;
 import org.apache.ibatis.logging.jdk14.Jdk14LoggingImpl;
 import org.apache.ibatis.logging.log4j.Log4jImpl;
 import org.apache.ibatis.logging.nologging.NoLoggingImpl;
 import org.apache.ibatis.logging.slf4j.Slf4jImpl;
 import org.apache.ibatis.logging.stdout.StdOutImpl;
+import org.apache.ibatis.session.SqlSessionFactoryBuilder;
 import org.junit.Test;
 
 public class LogFactoryTest {
@@ -75,6 +79,17 @@ public void shouldUseNoLogging() {
     assertEquals(log.getClass().getName(), NoLoggingImpl.class.getName());
   }
 
+  @Test
+  public void shouldReadLogImplFromSettings() throws Exception {
+    Reader reader = Resources.getResourceAsReader("org/apache/ibatis/logging/mybatis-config.xml");
+    new SqlSessionFactoryBuilder().build(reader);
+    reader.close();
+    
+    Log log = LogFactory.getLog(Object.class);
+    log.debug("Debug message.");
+    assertEquals(log.getClass().getName(), NoLoggingImpl.class.getName());
+  }
+
   private void logSomething(Log log) {
     log.warn("Warning message.");
     log.debug("Debug message.");

src/test/java/org/apache/ibatis/logging/mybatis-config.xml

@@ -0,0 +1,27 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!--
+       Copyright 2009-2012 The MyBatis Team
+
+       Licensed under the Apache License, Version 2.0 (the "License");
+       you may not use this file except in compliance with the License.
+       You may obtain a copy of the License at
+
+          http://www.apache.org/licenses/LICENSE-2.0
+
+       Unless required by applicable law or agreed to in writing, software
+       distributed under the License is distributed on an "AS IS" BASIS,
+       WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+       See the License for the specific language governing permissions and
+       limitations under the License.
+-->
+<!DOCTYPE configuration
+    PUBLIC "-//mybatis.org//DTD Config 3.0//EN"
+    "http://mybatis.org/dtd/mybatis-3-config.dtd">
+
+<configuration>
+
+    <settings>
+    	<setting name="logImpl" value="NO_LOGGING"/>
+    </settings>
+
+</configuration>