Skip to content

Commit 3e82947

Browse files
committed
Type handler mapped to Map is no longer invoked incorrectly
Follow up on #135
1 parent d2d9bac commit 3e82947

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/test/java/org/apache/ibatis/submitted/maptypehandler/MapTypeHandlerTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,19 @@
1515
*/
1616
package org.apache.ibatis.submitted.maptypehandler;
1717

18+
import static org.assertj.core.api.Assertions.*;
19+
1820
import java.io.Reader;
1921
import java.util.HashMap;
2022
import java.util.Map;
2123

2224
import org.apache.ibatis.BaseDataTest;
23-
import org.apache.ibatis.exceptions.PersistenceException;
2425
import org.apache.ibatis.io.Resources;
2526
import org.apache.ibatis.session.SqlSession;
2627
import org.apache.ibatis.session.SqlSessionFactory;
2728
import org.apache.ibatis.session.SqlSessionFactoryBuilder;
2829
import org.junit.jupiter.api.Assertions;
2930
import org.junit.jupiter.api.BeforeAll;
30-
import org.junit.jupiter.api.Disabled;
3131
import org.junit.jupiter.api.Test;
3232

3333
/**
@@ -59,15 +59,15 @@ void shouldGetAUserFromAnnotation() {
5959
}
6060
}
6161

62-
@Disabled("The new implementation handles this usage as expected")
6362
@Test
64-
void shouldGetAUserFromXML() {
63+
void shouldNotUseMapTypeHandlerEvenIfTheParamIsAMap() {
6564
try (SqlSession sqlSession = sqlSessionFactory.openSession()) {
6665
Mapper mapper = sqlSession.getMapper(Mapper.class);
6766
Map<String, Object> params = new HashMap<>();
6867
params.put("id", 1);
6968
params.put("name", "User1");
70-
Assertions.assertThrows(PersistenceException.class, () -> mapper.getUserXML(params));
69+
User user = mapper.getUserXML(params);
70+
assertThat(user).extracting(User::getId, User::getName).containsExactly(1, "User1");
7171
}
7272
}
7373

0 commit comments

Comments
 (0)