Merge pull request #986 from hazendaz/master

Update logging issues noted in eclipse/sonarlint

Author: hazendaz

src/main/java/org/apache/ibatis/io/ExternalResources.java

@@ -1,5 +1,5 @@
 /**
- *    Copyright 2009-2016 the original author or authors.
+ *    Copyright 2009-2017 the original author or authors.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
  *    you may not use this file except in compliance with the License.
@@ -24,12 +24,17 @@
 import java.nio.channels.FileChannel;
 import java.util.Properties;
 
+import org.apache.ibatis.logging.Log;
+import org.apache.ibatis.logging.LogFactory;
+
 /**
  * @author Clinton Begin
  */
 @Deprecated
 public class ExternalResources {
 
+  private static final Log log = LogFactory.getLog(ExternalResources.class);
+
   private ExternalResources() {
     // do nothing
   }
@@ -72,7 +77,7 @@ public static String getConfiguredTemplate(String templatePath, String templateP
     } catch (FileNotFoundException e) {
       throw e;
     } catch (Exception e) {
-      e.printStackTrace();
+      log.error("", e);
     }
 
     return templateName;

src/test/java/org/apache/ibatis/submitted/blocking_cache/BlockingCacheTest.java

@@ -1,5 +1,5 @@
 /**
- *    Copyright 2009-2015 the original author or authors.
+ *    Copyright 2009-2017 the original author or authors.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
  *    you may not use this file except in compliance with the License.
@@ -85,7 +85,7 @@ private void accessDB() {
       try {
         Thread.sleep(500);
       } catch (InterruptedException e) {
-        e.printStackTrace();
+        Assert.fail(e.getMessage());
       }
     } finally {
       sqlSession1.close();

src/test/java/org/apache/ibatis/submitted/null_associations/FooMapperTest.java

@@ -1,5 +1,5 @@
 /**
- *    Copyright 2009-2015 the original author or authors.
+ *    Copyright 2009-2017 the original author or authors.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
  *    you may not use this file except in compliance with the License.
@@ -42,7 +42,7 @@ public static void setUpBeforeClass() {
       Reader reader = Resources.getResourceAsReader("org/apache/ibatis/submitted/null_associations/create-schema-mysql.sql");
       runner.runScript(reader);
     } catch (Exception ex) {
-      ex.printStackTrace();
+      Assert.fail(ex.getMessage());
     }
   }
 

src/test/java/org/apache/ibatis/submitted/overwritingproperties/FooMapperTest.java

@@ -43,7 +43,7 @@ public static void setUpBeforeClass() {
       Reader reader = Resources.getResourceAsReader("org/apache/ibatis/submitted/overwritingproperties/create-schema-mysql.sql");
       runner.runScript(reader);
     } catch (Exception ex) {
-      ex.printStackTrace();
+      Assert.fail(ex.getMessage());
     }
   }