Only free() the Array if it was created by us. We leave the management of user supplied Arrays to the user.

Author: dirk-olmes

src/main/java/org/apache/ibatis/type/ArrayTypeHandler.java

@@ -40,17 +40,19 @@ protected void setNullParameter(PreparedStatement ps, int i, JdbcType jdbcType)
   public void setNonNullParameter(PreparedStatement ps, int i, Object parameter, JdbcType jdbcType) throws SQLException {
     Array array = null;
     if (parameter instanceof Array) {
-      array = (Array)parameter;
+      // it's the user's responsibility to properly free() the Array instance
+      ps.setArray(i, (Array)parameter);
+      
     }
     else {
       if (!parameter.getClass().isArray()) {
         throw new TypeException("ArrayType Handler requires SQL array or java array parameter and does not support type " + parameter.getClass());
       }
       Object[] values = (Object[])parameter;
       array = ps.getConnection().createArrayOf(jdbcType.name(), values);
+      ps.setArray(i, array);
+      array.free();
     }
-    ps.setArray(i, array);
-    array.free();
   }
 
   @Override

src/test/java/org/apache/ibatis/type/ArrayTypeHandlerTest.java

@@ -39,9 +39,8 @@ class ArrayTypeHandlerTest extends BaseTypeHandlerTest {
   public void shouldSetParameter() throws Exception {
     TYPE_HANDLER.setParameter(ps, 1, mockArray, null);
     verify(ps).setArray(1, mockArray);
-    verify(mockArray).free();
   }
-  
+    
   @Test
   public void shouldSetNullParameter() throws Exception {
     TYPE_HANDLER.setParameter(ps, 1, null, JdbcType.ARRAY);