Skip to content

Commit 6e79446

Browse files
authored
Merge pull request #2028 from nothingzhl/pr_optimization
Combined return value
2 parents 0bc1ffb + 74db267 commit 6e79446

File tree

1 file changed

+13
-65
lines changed

1 file changed

+13
-65
lines changed

src/main/java/org/apache/ibatis/parsing/XNode.java

Lines changed: 13 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -130,71 +130,47 @@ public String getStringBody() {
130130
}
131131

132132
public String getStringBody(String def) {
133-
if (body == null) {
134-
return def;
135-
} else {
136-
return body;
137-
}
133+
return body == null ? def : body;
138134
}
139135

140136
public Boolean getBooleanBody() {
141137
return getBooleanBody(null);
142138
}
143139

144140
public Boolean getBooleanBody(Boolean def) {
145-
if (body == null) {
146-
return def;
147-
} else {
148-
return Boolean.valueOf(body);
149-
}
141+
return body == null ? def : Boolean.valueOf(body);
150142
}
151143

152144
public Integer getIntBody() {
153145
return getIntBody(null);
154146
}
155147

156148
public Integer getIntBody(Integer def) {
157-
if (body == null) {
158-
return def;
159-
} else {
160-
return Integer.parseInt(body);
161-
}
149+
return body == null ? def : Integer.valueOf(body);
162150
}
163151

164152
public Long getLongBody() {
165153
return getLongBody(null);
166154
}
167155

168156
public Long getLongBody(Long def) {
169-
if (body == null) {
170-
return def;
171-
} else {
172-
return Long.parseLong(body);
173-
}
157+
return body == null ? def : Long.valueOf(body);
174158
}
175159

176160
public Double getDoubleBody() {
177161
return getDoubleBody(null);
178162
}
179163

180164
public Double getDoubleBody(Double def) {
181-
if (body == null) {
182-
return def;
183-
} else {
184-
return Double.parseDouble(body);
185-
}
165+
return body == null ? def : Double.valueOf(body);
186166
}
187167

188168
public Float getFloatBody() {
189169
return getFloatBody(null);
190170
}
191171

192172
public Float getFloatBody(Float def) {
193-
if (body == null) {
194-
return def;
195-
} else {
196-
return Float.parseFloat(body);
197-
}
173+
return body == null ? def : Float.valueOf(body);
198174
}
199175

200176
public <T extends Enum<T>> T getEnumAttribute(Class<T> enumType, String name) {
@@ -203,11 +179,7 @@ public <T extends Enum<T>> T getEnumAttribute(Class<T> enumType, String name) {
203179

204180
public <T extends Enum<T>> T getEnumAttribute(Class<T> enumType, String name, T def) {
205181
String value = getStringAttribute(name);
206-
if (value == null) {
207-
return def;
208-
} else {
209-
return Enum.valueOf(enumType, value);
210-
}
182+
return value == null ? def : Enum.valueOf(enumType,value);
211183
}
212184

213185
/**
@@ -234,11 +206,7 @@ public String getStringAttribute(String name) {
234206

235207
public String getStringAttribute(String name, String def) {
236208
String value = attributes.getProperty(name);
237-
if (value == null) {
238-
return def;
239-
} else {
240-
return value;
241-
}
209+
return value == null ? def : value;
242210
}
243211

244212
public Boolean getBooleanAttribute(String name) {
@@ -247,11 +215,7 @@ public Boolean getBooleanAttribute(String name) {
247215

248216
public Boolean getBooleanAttribute(String name, Boolean def) {
249217
String value = attributes.getProperty(name);
250-
if (value == null) {
251-
return def;
252-
} else {
253-
return Boolean.valueOf(value);
254-
}
218+
return value == null ? def : Boolean.valueOf(value);
255219
}
256220

257221
public Integer getIntAttribute(String name) {
@@ -260,11 +224,7 @@ public Integer getIntAttribute(String name) {
260224

261225
public Integer getIntAttribute(String name, Integer def) {
262226
String value = attributes.getProperty(name);
263-
if (value == null) {
264-
return def;
265-
} else {
266-
return Integer.parseInt(value);
267-
}
227+
return value == null ? def : Integer.valueOf(value);
268228
}
269229

270230
public Long getLongAttribute(String name) {
@@ -273,11 +233,7 @@ public Long getLongAttribute(String name) {
273233

274234
public Long getLongAttribute(String name, Long def) {
275235
String value = attributes.getProperty(name);
276-
if (value == null) {
277-
return def;
278-
} else {
279-
return Long.parseLong(value);
280-
}
236+
return value == null ? def : Long.valueOf(value);
281237
}
282238

283239
public Double getDoubleAttribute(String name) {
@@ -286,11 +242,7 @@ public Double getDoubleAttribute(String name) {
286242

287243
public Double getDoubleAttribute(String name, Double def) {
288244
String value = attributes.getProperty(name);
289-
if (value == null) {
290-
return def;
291-
} else {
292-
return Double.parseDouble(value);
293-
}
245+
return value == null ? def : Double.valueOf(value);
294246
}
295247

296248
public Float getFloatAttribute(String name) {
@@ -299,11 +251,7 @@ public Float getFloatAttribute(String name) {
299251

300252
public Float getFloatAttribute(String name, Float def) {
301253
String value = attributes.getProperty(name);
302-
if (value == null) {
303-
return def;
304-
} else {
305-
return Float.parseFloat(value);
306-
}
254+
return value == null ? def : Float.valueOf(value);
307255
}
308256

309257
public List<XNode> getChildren() {

0 commit comments

Comments
 (0)