Skip to content

Commit 79d7ff9

Browse files
committed
Fix for http://code.google.com/p/mybatis/issues/detail?id=304 - Incorrect syntax for joins in SqlBuilder and SelectBuilder
1 parent 3086caa commit 79d7ff9

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/main/java/org/apache/ibatis/jdbc/SelectBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public static String SQL() {
8787
}
8888

8989
selectClause(builder, "FROM", sql().from, "", "", ", ");
90-
selectClause(builder, "JOIN", sql().join, "", "", "JOIN");
90+
selectClause(builder, "JOIN", sql().join, "", "", "\nJOIN ");
9191
selectClause(builder, "INNER JOIN", sql().innerJoin, "", "", "\nINNER JOIN ");
9292
selectClause(builder, "OUTER JOIN", sql().outerJoin, "", "", "\nOUTER JOIN ");
9393
selectClause(builder, "LEFT OUTER JOIN", sql().leftOuterJoin, "", "", "\nLEFT OUTER JOIN ");

src/main/java/org/apache/ibatis/jdbc/SqlBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ private String selectSQL() {
172172
}
173173

174174
sqlClause(builder, "FROM", tables, "", "", ", ");
175-
sqlClause(builder, "JOIN", join, "", "", "JOIN");
175+
sqlClause(builder, "JOIN", join, "", "", "\nJOIN ");
176176
sqlClause(builder, "INNER JOIN", innerJoin, "", "", "\nINNER JOIN ");
177177
sqlClause(builder, "OUTER JOIN", outerJoin, "", "", "\nOUTER JOIN ");
178178
sqlClause(builder, "LEFT OUTER JOIN", leftOuterJoin, "", "", "\nLEFT OUTER JOIN ");

0 commit comments

Comments
 (0)