Skip to content

Commit 7dcd2a9

Browse files
committed
Fixed close leakage of SqlSession
1 parent 9dfbbc2 commit 7dcd2a9

File tree

1 file changed

+35
-16
lines changed

1 file changed

+35
-16
lines changed

src/test/java/org/apache/ibatis/submitted/batch_keys/BatchKeysTest.java

Lines changed: 35 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -104,10 +104,13 @@ public void testInsert() throws Exception {
104104
} finally {
105105
sqlSession.close();
106106
}
107-
108-
sqlSession = sqlSessionFactory.openSession();
109-
List<User> users = sqlSession.selectList("select");
110-
Assert.assertTrue(users.size() == 2);
107+
try {
108+
sqlSession = sqlSessionFactory.openSession();
109+
List<User> users = sqlSession.selectList("select");
110+
Assert.assertTrue(users.size() == 2);
111+
} finally {
112+
sqlSession.close();
113+
}
111114
}
112115

113116

@@ -127,9 +130,13 @@ public void testInsertJdbc3() throws Exception {
127130
sqlSession.close();
128131
}
129132

130-
sqlSession = sqlSessionFactory.openSession();
131-
List<User> users = sqlSession.selectList("selectIdentity");
132-
Assert.assertTrue(users.size() == 2);
133+
try {
134+
sqlSession = sqlSessionFactory.openSession();
135+
List<User> users = sqlSession.selectList("selectIdentity");
136+
Assert.assertTrue(users.size() == 2);
137+
} finally {
138+
sqlSession.close();
139+
}
133140
}
134141

135142
@Test
@@ -149,9 +156,13 @@ public void testInsertWithMapper() throws Exception {
149156
sqlSession.close();
150157
}
151158

152-
sqlSession = sqlSessionFactory.openSession();
153-
List<User> users = sqlSession.selectList("select");
154-
Assert.assertTrue(users.size() == 2);
159+
try {
160+
sqlSession = sqlSessionFactory.openSession();
161+
List<User> users = sqlSession.selectList("select");
162+
Assert.assertTrue(users.size() == 2);
163+
} finally {
164+
sqlSession.close();
165+
}
155166
}
156167

157168
@Test
@@ -171,9 +182,13 @@ public void testInsertMapperJdbc3() throws Exception {
171182
sqlSession.close();
172183
}
173184

174-
sqlSession = sqlSessionFactory.openSession();
175-
List<User> users = sqlSession.selectList("selectIdentity");
176-
Assert.assertTrue(users.size() == 2);
185+
try {
186+
sqlSession = sqlSessionFactory.openSession();
187+
List<User> users = sqlSession.selectList("selectIdentity");
188+
Assert.assertTrue(users.size() == 2);
189+
} finally {
190+
sqlSession.close();
191+
}
177192
}
178193

179194
@Test
@@ -189,9 +204,13 @@ public void testInsertMapperNoBatchJdbc3() throws Exception {
189204
sqlSession.close();
190205
}
191206

192-
sqlSession = sqlSessionFactory.openSession();
193-
List<User> users = sqlSession.selectList("selectIdentity");
194-
Assert.assertTrue(users.size() == 1);
207+
try {
208+
sqlSession = sqlSessionFactory.openSession();
209+
List<User> users = sqlSession.selectList("selectIdentity");
210+
Assert.assertTrue(users.size() == 1);
211+
} finally {
212+
sqlSession.close();
213+
}
195214
}
196215

197216
}

0 commit comments

Comments
 (0)