Skip to content

Commit 8b71304

Browse files
emacarronemacarron
committed
Test case for #421 
1 parent 2d6aed5 commit 8b71304

File tree

6 files changed

+214
-0
lines changed

6 files changed

+214
-0
lines changed

‎src/test/java/org/apache/ibatis/submitted/emptycollection/Dao.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
package org.apache.ibatis.submitted.emptycollection;
2+
3+
import java.util.List;
4+
5+
interface Dao {
6+
List<TodoLists> selectWithEmptyList();
7+
List<TodoLists> selectWithNonEmptyList();
8+
List<TodoLists> selectWithNonEmptyList_noCollectionId();
9+
}

‎src/test/java/org/apache/ibatis/submitted/emptycollection/Dao.xml

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN" "http://mybatis.org/dtd/mybatis-3-mapper.dtd">
3+
4+
<mapper namespace="org.apache.ibatis.submitted.emptycollection.Dao">
5+
<select id="selectWithEmptyList" resultMap="selectList">
6+
select 1 id, null "order", null description from (VALUES ('dummy')) dummy(dummy)
7+
</select>
8+
9+
<select id="selectWithNonEmptyList" resultMap="selectList">
10+
select 1 id, 1 "order", 'a description' description from (VALUES ('dummy')) dummy(dummy)
11+
union all select 1 id, 2 "order", 'a 2nd description' description from (VALUES ('dummy')) dummy(dummy)
12+
union all select 2 id, 1 "order", 'a description' description from (VALUES ('dummy')) dummy(dummy)
13+
</select>
14+
15+
<select id="selectWithNonEmptyList_noCollectionId" resultMap="selectList_noCollectionId">
16+
select 1 id, 1 "order", 'a description' description from (VALUES ('dummy')) dummy(dummy)
17+
union all select 1 id, 2 "order", 'a 2nd description' description from (VALUES ('dummy')) dummy(dummy)
18+
union all select 2 id, 1 "order", 'a description' description from (VALUES ('dummy')) dummy(dummy)
19+
</select>
20+
21+
22+
<resultMap id="selectList" type="org.apache.ibatis.submitted.emptycollection.TodoLists">
23+
<id column="id" property="id" />
24+
<collection property="todoItems" ofType="org.apache.ibatis.submitted.emptycollection.TodoItem" javaType="list">
25+
<id column="id" />
26+
<id column="order" property="order" />
27+
<result column="description" property="description"/>
28+
</collection>
29+
</resultMap>
30+
31+
<resultMap id="selectList_noCollectionId" type="org.apache.ibatis.submitted.emptycollection.TodoLists">
32+
<id column="id" property="id" />
33+
<collection property="todoItems" ofType="org.apache.ibatis.submitted.emptycollection.TodoItem" javaType="list">
34+
<id column="order" property="order" />
35+
<result column="description" property="description"/>
36+
</collection>
37+
</resultMap>
38+
39+
</mapper>

‎src/test/java/org/apache/ibatis/submitted/emptycollection/DaoTest.java

Lines changed: 84 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,84 @@
1+
package org.apache.ibatis.submitted.emptycollection;
2+
3+
import org.apache.ibatis.io.Resources;
4+
import org.apache.ibatis.jdbc.ScriptRunner;
5+
import org.apache.ibatis.session.SqlSession;
6+
import org.apache.ibatis.session.SqlSessionFactory;
7+
import org.apache.ibatis.session.SqlSessionFactoryBuilder;
8+
import org.apache.ibatis.submitted.emptycollection.Dao;
9+
import org.apache.ibatis.submitted.emptycollection.TodoLists;
10+
import org.junit.After;
11+
import org.junit.Assert;
12+
import org.junit.Before;
13+
import org.junit.Test;
14+
15+
import java.io.Reader;
16+
import java.sql.Connection;
17+
import java.util.HashMap;
18+
import java.util.HashSet;
19+
import java.util.List;
20+
21+
import static java.util.Arrays.asList;
22+
23+
public class DaoTest {
24+
private Dao dao;
25+
private SqlSession sqlSession;
26+
27+
@Before
28+
public void setUp() throws Exception {
29+
Reader reader = Resources.getResourceAsReader("org/apache/ibatis/submitted/emptycollection/mybatis-config.xml");
30+
SqlSessionFactory sqlSessionFactory = new SqlSessionFactoryBuilder().build(reader);
31+
reader.close();
32+
33+
sqlSession = sqlSessionFactory.openSession();
34+
Connection conn = sqlSession.getConnection();
35+
ScriptRunner runner = new ScriptRunner(conn);
36+
runner.setLogWriter(null);
37+
dao = sqlSession.getMapper(Dao.class);
38+
}
39+
40+
@After
41+
public void tearDown() throws Exception {
42+
sqlSession.close();
43+
}
44+
45+
@Test
46+
public void testWithEmptyList() throws Exception {
47+
final List<TodoLists> actual = dao.selectWithEmptyList();
48+
49+
Assert.assertEquals(1, actual.size());
50+
}
51+
52+
@Test
53+
public void testWithNonEmptyList() throws Exception {
54+
final List<TodoLists> actual = dao.selectWithNonEmptyList();
55+
56+
checkNonEmptyList(actual);
57+
}
58+
59+
@Test
60+
public void testWithNonEmptyList_noCollectionId() throws Exception {
61+
final List<TodoLists> actual = dao.selectWithNonEmptyList_noCollectionId();
62+
63+
checkNonEmptyList(actual);
64+
}
65+
66+
private void checkNonEmptyList(final List<TodoLists> actual) {
67+
// Assert.assertEquals("[List(1)=[a description(1), a 2nd description(2)], List(2)=[a description(1)]]", actual.toString());
68+
Assert.assertEquals(2, actual.size());
69+
70+
Assert.assertEquals(2, actual.get(0).getTodoItems().size());
71+
Assert.assertEquals(1, actual.get(0).getTodoItems().get(0).getOrder());
72+
Assert.assertEquals("a description", actual.get(0).getTodoItems().get(0).getDescription().trim());
73+
Assert.assertEquals(2, actual.get(0).getTodoItems().get(1).getOrder());
74+
Assert.assertEquals("a 2nd description", actual.get(0).getTodoItems().get(1).getDescription().trim());
75+
76+
Assert.assertEquals(1, actual.get(1).getTodoItems().size());
77+
Assert.assertEquals(1, actual.get(1).getTodoItems().get(0).getOrder());
78+
Assert.assertEquals("a description", actual.get(0).getTodoItems().get(0).getDescription().trim());
79+
80+
// We should have gotten three item objects. The first item from the first list and the first item from
81+
// the second list have identical properties, but they should be distinct objects
82+
Assert.assertNotSame(actual.get(0).getTodoItems().get(0), actual.get(1).getTodoItems().get(0));
83+
}
84+
}

‎src/test/java/org/apache/ibatis/submitted/emptycollection/TodoItem.java

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
package org.apache.ibatis.submitted.emptycollection;
2+
3+
public class TodoItem {
4+
5+
@Override
6+
public String toString() {
7+
return "TodoItem [order=" + order + ", description=" + description + "]";
8+
}
9+
10+
private int order;
11+
private String description;
12+
13+
public int getOrder() {
14+
return order;
15+
}
16+
17+
public void setOrder(int order) {
18+
this.order = order;
19+
}
20+
21+
public String getDescription() {
22+
return description;
23+
}
24+
25+
public void setDescription(String description) {
26+
this.description = description;
27+
}
28+
29+
}

‎src/test/java/org/apache/ibatis/submitted/emptycollection/TodoLists.java

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
package org.apache.ibatis.submitted.emptycollection;
2+
3+
import java.util.List;
4+
5+
public class TodoLists {
6+
7+
@Override
8+
public String toString() {
9+
return "TodoLists [id=" + id + ", todoItems=" + todoItems + "]";
10+
}
11+
12+
private int id;
13+
14+
private List<TodoItem> todoItems;
15+
16+
public int getId() {
17+
return id;
18+
}
19+
20+
public void setId(int id) {
21+
this.id = id;
22+
}
23+
24+
public List<TodoItem> getTodoItems() {
25+
return todoItems;
26+
}
27+
28+
public void setTodoItems(List<TodoItem> todoItems) {
29+
this.todoItems = todoItems;
30+
}
31+
32+
}

‎src/test/java/org/apache/ibatis/submitted/emptycollection/mybatis-config.xml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
<?xml version="1.0" encoding="UTF-8" ?>
2+
<!DOCTYPE configuration
3+
PUBLIC "-//mybatis.org//DTD Config 3.0//EN"
4+
"http://mybatis.org/dtd/mybatis-3-config.dtd">
5+
<configuration>
6+
<environments default="development">
7+
<environment id="development">
8+
<transactionManager type="JDBC">
9+
<property name="" value="" />
10+
</transactionManager>
11+
<dataSource type="UNPOOLED">
12+
<property name="driver" value="org.hsqldb.jdbcDriver" />
13+
<property name="url" value="jdbc:hsqldb:mem:emptycollection" />
14+
<property name="username" value="sa" />
15+
</dataSource>
16+
</environment>
17+
</environments>
18+
<mappers>
19+
<mapper resource="org/apache/ibatis/submitted/emptycollection/Dao.xml" />
20+
</mappers>
21+
</configuration>

0 commit comments

Comments
 (0)