Test case for issue #1848

Author: emacarron

src/test/java/org/apache/ibatis/submitted/parent_childs/Child.java

@@ -17,16 +17,27 @@
 
 public class Child {
 
-  private int id;
+  private Integer id;
   private String name;
   private String surName;
-  private int age;
+  private Integer age;
 
-  public int getId() {
+  public Child() {
+	  
+  }
+  
+  public Child(Integer id, String name, String surName, Integer age) {
+    this.id = id;
+    this.name = name;
+    this.surName = surName;
+    this.age = age;
+  }
+  
+  public Integer getId() {
     return id;
   }
 
-  public void setId(int id) {
+  public void setId(Integer id) {
     this.id = id;
   }
 

src/test/java/org/apache/ibatis/submitted/parent_childs/Mapper.java

@@ -20,5 +20,6 @@
 public interface Mapper {
 
   List<Parent> getParents();
+  List<Parent> getParentsWithConstructor();
 
 }

src/test/java/org/apache/ibatis/submitted/parent_childs/Mapper.xml

@@ -23,17 +23,17 @@
 <mapper namespace="org.apache.ibatis.submitted.parent_childs.Mapper">
 
     <resultMap id="ParentMap" type="org.apache.ibatis.submitted.parent_childs.Parent">
-        <id column="p_Id" property="id" />
-        <id column="p_Name" property="name" />
-        <id column="p_SurName" property="surName" />
+        <result column="p_Id" property="id" />
+        <result column="p_Name" property="name" />
+        <result column="p_SurName" property="surName" />
         <collection property="childs" resultMap="ChildMap" />
     </resultMap>
 
     <resultMap id="ChildMap" type="org.apache.ibatis.submitted.parent_childs.Child">
-        <id column="c_id" property="id" />
-        <id column="c_Name" property="name" />
-        <id column="c_SurName" property="surName" />
-        <id column="c_Age" property="age" />
+        <result column="c_id" property="id" />
+        <result column="c_Name" property="name" />
+        <result column="c_SurName" property="surName" />
+        <result column="c_Age" property="age" />
     </resultMap>
 
     <select id="getParents" resultMap="ParentMap">
@@ -48,4 +48,34 @@
         from Parent p
         left outer join Child c on p.Id = c.ParentId
     </select>
+        
+    <resultMap id="ParentMapConstructor" type="org.apache.ibatis.submitted.parent_childs.Parent">
+        <result column="p_Id" property="id" />
+        <result column="p_Name" property="name" />
+        <result column="p_SurName" property="surName" />
+        <collection property="childs" resultMap="ChildMapConstructor" />
+    </resultMap>
+
+    <resultMap id="ChildMapConstructor" type="org.apache.ibatis.submitted.parent_childs.Child">
+        <constructor>
+	        <arg column="c_id" javaType="int"/>
+	        <arg column="c_Name" javaType="String"/>
+	        <arg column="c_SurName" javaType="String"/>
+	        <arg column="c_Age" javaType="int"/>
+        </constructor>
+    </resultMap>
+    
+    <select id="getParentsWithConstructor" resultMap="ParentMapConstructor">
+        select
+        p.Id as p_Id,
+        p.Name as p_Name,
+        p.SurName as p_SurName,
+        c.Id as c_Id,
+        c.Name as c_Name,
+        c.SurName as c_SurName,
+        c.Age as c_Age
+        from Parent p
+        left outer join Child c on p.Id = c.ParentId
+    </select>
+    
 </mapper>

src/test/java/org/apache/ibatis/submitted/parent_childs/ParentChildTest.java

@@ -23,6 +23,7 @@
 import org.apache.ibatis.session.SqlSession;
 import org.apache.ibatis.session.SqlSessionFactory;
 import org.apache.ibatis.session.SqlSessionFactoryBuilder;
+import org.junit.Ignore;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
@@ -34,17 +35,18 @@ class ParentChildTest {
   @BeforeAll
   static void setUp() throws Exception {
     // create a SqlSessionFactory
-    try (Reader reader = Resources.getResourceAsReader("org/apache/ibatis/submitted/parent_childs/mybatis-config.xml")) {
+    try (
+        Reader reader = Resources.getResourceAsReader("org/apache/ibatis/submitted/parent_childs/mybatis-config.xml")) {
       sqlSessionFactory = new SqlSessionFactoryBuilder().build(reader);
     }
 
     // populate in-memory database
     BaseDataTest.runScript(sqlSessionFactory.getConfiguration().getEnvironment().getDataSource(),
-            "org/apache/ibatis/submitted/parent_childs/CreateDB.sql");
+        "org/apache/ibatis/submitted/parent_childs/CreateDB.sql");
   }
 
   @Test
-  void shouldGetAUser() {
+  void shouldGet2Parents() {
     try (SqlSession sqlSession = sqlSessionFactory.openSession()) {
       Mapper mapper = sqlSession.getMapper(Mapper.class);
       List<Parent> parents = mapper.getParents();
@@ -58,4 +60,21 @@ void shouldGetAUser() {
     }
   }
 
+  // issue #1848
+  @Test
+  @Ignore
+  void shouldGet2ParentsWithConstructor() {
+    try (SqlSession sqlSession = sqlSessionFactory.openSession()) {
+      Mapper mapper = sqlSession.getMapper(Mapper.class);
+      List<Parent> parents = mapper.getParentsWithConstructor();
+      Assertions.assertEquals(2, parents.size());
+      Parent firstParent = parents.get(0);
+      Assertions.assertEquals("Jose", firstParent.getName());
+      Assertions.assertEquals(2, firstParent.getChilds().size());
+      Parent secondParent = parents.get(1);
+      Assertions.assertEquals("Juan", secondParent.getName());
+      Assertions.assertEquals(0, secondParent.getChilds().size()); // note an empty list is inyected
+    }
+  }
+
 }