[ci] Checkstyle cleanup

Author: hazendaz

src/main/java/org/apache/ibatis/cursor/defaults/DefaultCursor.java

@@ -15,6 +15,11 @@
  */
 package org.apache.ibatis.cursor.defaults;
 
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.util.Iterator;
+import java.util.NoSuchElementException;
+
 import org.apache.ibatis.cursor.Cursor;
 import org.apache.ibatis.executor.resultset.DefaultResultSetHandler;
 import org.apache.ibatis.executor.resultset.ResultSetWrapper;
@@ -23,11 +28,6 @@
 import org.apache.ibatis.session.ResultHandler;
 import org.apache.ibatis.session.RowBounds;
 
-import java.sql.ResultSet;
-import java.sql.SQLException;
-import java.util.Iterator;
-import java.util.NoSuchElementException;
-
 /**
  * This is the default implementation of a MyBatis Cursor.
  * This implementation is not thread safe.

src/main/java/org/apache/ibatis/datasource/pooled/PooledConnection.java

@@ -42,7 +42,7 @@ class PooledConnection implements InvocationHandler {
   private boolean valid;
 
   /**
-   * Constructor for SimplePooledConnection that uses the Connection and PooledDataSource passed in
+   * Constructor for SimplePooledConnection that uses the Connection and PooledDataSource passed in.
    *
    * @param connection - the connection that is to be presented as a pooled connection
    * @param dataSource - the dataSource that the connection is from
@@ -58,14 +58,14 @@ public PooledConnection(Connection connection, PooledDataSource dataSource) {
   }
 
   /**
-   * Invalidates the connection
+   * Invalidates the connection.
    */
   public void invalidate() {
     valid = false;
   }
 
   /**
-   * Method to see if the connection is usable
+   * Method to see if the connection is usable.
    *
    * @return True if the connection is usable
    */
@@ -74,7 +74,7 @@ public boolean isValid() {
   }
 
   /**
-   * Getter for the *real* connection that this wraps
+   * Getter for the *real* connection that this wraps.
    *
    * @return The connection
    */
@@ -83,7 +83,7 @@ public Connection getRealConnection() {
   }
 
   /**
-   * Getter for the proxy for the connection
+   * Getter for the proxy for the connection.
    *
    * @return The proxy
    */
@@ -92,7 +92,7 @@ public Connection getProxyConnection() {
   }
 
   /**
-   * Gets the hashcode of the real connection (or 0 if it is null)
+   * Gets the hashcode of the real connection (or 0 if it is null).
    *
    * @return The hashcode of the real connection (or 0 if it is null)
    */
@@ -101,7 +101,7 @@ public int getRealHashCode() {
   }
 
   /**
-   * Getter for the connection type (based on url + user + password)
+   * Getter for the connection type (based on url + user + password).
    *
    * @return The connection type
    */
@@ -110,7 +110,7 @@ public int getConnectionTypeCode() {
   }
 
   /**
-   * Setter for the connection type
+   * Setter for the connection type.
    *
    * @param connectionTypeCode - the connection type
    */
@@ -119,7 +119,7 @@ public void setConnectionTypeCode(int connectionTypeCode) {
   }
 
   /**
-   * Getter for the time that the connection was created
+   * Getter for the time that the connection was created.
    *
    * @return The creation timestamp
    */
@@ -128,7 +128,7 @@ public long getCreatedTimestamp() {
   }
 
   /**
-   * Setter for the time that the connection was created
+   * Setter for the time that the connection was created.
    *
    * @param createdTimestamp - the timestamp
    */
@@ -137,7 +137,7 @@ public void setCreatedTimestamp(long createdTimestamp) {
   }
 
   /**
-   * Getter for the time that the connection was last used
+   * Getter for the time that the connection was last used.
    *
    * @return - the timestamp
    */
@@ -146,7 +146,7 @@ public long getLastUsedTimestamp() {
   }
 
   /**
-   * Setter for the time that the connection was last used
+   * Setter for the time that the connection was last used.
    *
    * @param lastUsedTimestamp - the timestamp
    */
@@ -155,7 +155,7 @@ public void setLastUsedTimestamp(long lastUsedTimestamp) {
   }
 
   /**
-   * Getter for the time since this connection was last used
+   * Getter for the time since this connection was last used.
    *
    * @return - the time since the last use
    */
@@ -164,7 +164,7 @@ public long getTimeElapsedSinceLastUse() {
   }
 
   /**
-   * Getter for the age of the connection
+   * Getter for the age of the connection.
    *
    * @return the age
    */
@@ -173,7 +173,7 @@ public long getAge() {
   }
 
   /**
-   * Getter for the timestamp that this connection was checked out
+   * Getter for the timestamp that this connection was checked out.
    *
    * @return the timestamp
    */
@@ -182,7 +182,7 @@ public long getCheckoutTimestamp() {
   }
 
   /**
-   * Setter for the timestamp that this connection was checked out
+   * Setter for the timestamp that this connection was checked out.
    *
    * @param timestamp the timestamp
    */
@@ -191,7 +191,7 @@ public void setCheckoutTimestamp(long timestamp) {
   }
 
   /**
-   * Getter for the time that this connection has been checked out
+   * Getter for the time that this connection has been checked out.
    *
    * @return the time
    */
@@ -205,7 +205,7 @@ public int hashCode() {
   }
 
   /**
-   * Allows comparing this connection to another
+   * Allows comparing this connection to another.
    *
    * @param obj - the other connection to test for equality
    * @see Object#equals(Object)

src/main/java/org/apache/ibatis/datasource/pooled/PooledDataSource.java

@@ -150,7 +150,7 @@ public void setDriverProperties(Properties driverProps) {
   }
 
   /**
-   * The maximum number of active connections
+   * The maximum number of active connections.
    *
    * @param poolMaximumActiveConnections The maximum number of active connections
    */
@@ -160,7 +160,7 @@ public void setPoolMaximumActiveConnections(int poolMaximumActiveConnections) {
   }
 
   /**
-   * The maximum number of idle connections
+   * The maximum number of idle connections.
    *
    * @param poolMaximumIdleConnections The maximum number of idle connections
    */
@@ -171,7 +171,7 @@ public void setPoolMaximumIdleConnections(int poolMaximumIdleConnections) {
 
   /**
    * The maximum number of tolerance for bad connection happens in one thread
-    * which are applying for new {@link PooledConnection}
+   * which are applying for new {@link PooledConnection}.
    *
    * @param poolMaximumLocalBadConnectionTolerance
    * max tolerance for bad connection happens in one thread
@@ -195,7 +195,7 @@ public void setPoolMaximumCheckoutTime(int poolMaximumCheckoutTime) {
   }
 
   /**
-   * The time to wait before retrying to get a connection
+   * The time to wait before retrying to get a connection.
    *
    * @param poolTimeToWait The time to wait
    */
@@ -205,7 +205,7 @@ public void setPoolTimeToWait(int poolTimeToWait) {
   }
 
   /**
-   * The query to be used to check a connection
+   * The query to be used to check a connection.
    *
    * @param poolPingQuery The query
    */
@@ -295,8 +295,8 @@ public int getPoolPingConnectionsNotUsedFor() {
     return poolPingConnectionsNotUsedFor;
   }
 
-  /*
-   * Closes all active and idle connections in the pool
+  /**
+   * Closes all active and idle connections in the pool.
    */
   public void forceCloseAll() {
     synchronized (state) {
@@ -580,7 +580,7 @@ public boolean isWrapperFor(Class<?> iface) {
   }
 
   public Logger getParentLogger() {
-    return Logger.getLogger(Logger.GLOBAL_LOGGER_NAME); // requires JDK version 1.6
+    return Logger.getLogger(Logger.GLOBAL_LOGGER_NAME);
   }
 
 }