Skip to content

Commit a101970

Browse files
committed
[hsqldb] Now handles timezone so we must use bogus timezones for tests to continue to work negatively as they suggest
1 parent 04f933b commit a101970

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/test/java/org/apache/ibatis/submitted/timezone_edge_case/TimezoneEdgeCaseTest.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,8 @@ void restoreTimeZone() {
6363

6464
@Test
6565
void shouldSelectNonExistentLocalTimestampAsIs() {
66-
TimeZone.setDefault(TimeZone.getTimeZone("America/Los_Angeles"));
66+
// Newer hsqldb requires we use a bogus timezone as timezone now works
67+
TimeZone.setDefault(TimeZone.getTimeZone("Bad/Zone"));
6768
try (SqlSession sqlSession = sqlSessionFactory.openSession()) {
6869
Mapper mapper = sqlSession.getMapper(Mapper.class);
6970
Record record = mapper.selectById(1);
@@ -73,7 +74,8 @@ void shouldSelectNonExistentLocalTimestampAsIs() {
7374

7475
@Test
7576
void shouldInsertNonExistentLocalTimestampAsIs() throws Exception {
76-
TimeZone.setDefault(TimeZone.getTimeZone("America/Los_Angeles"));
77+
// Newer hsqldb requires we use a bogus timezone as timezone now works
78+
TimeZone.setDefault(TimeZone.getTimeZone("Bad/Zone"));
7779
LocalDateTime localDateTime = LocalDateTime.of(LocalDate.of(2019, 3, 10), LocalTime.of(2, 30));
7880
try (SqlSession sqlSession = sqlSessionFactory.openSession()) {
7981
Mapper mapper = sqlSession.getMapper(Mapper.class);
@@ -93,7 +95,8 @@ void shouldInsertNonExistentLocalTimestampAsIs() throws Exception {
9395

9496
@Test
9597
void shouldSelectNonExistentLocalDateAsIs() {
96-
TimeZone.setDefault(TimeZone.getTimeZone("Pacific/Apia"));
98+
// Newer hsqldb requires we use a bogus timezone as timezone now works
99+
TimeZone.setDefault(TimeZone.getTimeZone("Bad/Zone"));
97100
try (SqlSession sqlSession = sqlSessionFactory.openSession()) {
98101
Mapper mapper = sqlSession.getMapper(Mapper.class);
99102
Record record = mapper.selectById(1);
@@ -103,7 +106,8 @@ void shouldSelectNonExistentLocalDateAsIs() {
103106

104107
@Test
105108
void shouldInsertNonExistentLocalDateAsIs() throws Exception {
106-
TimeZone.setDefault(TimeZone.getTimeZone("Pacific/Apia"));
109+
// Newer hsqldb requires we use a bogus timezone as timezone now works
110+
TimeZone.setDefault(TimeZone.getTimeZone("Bad/Zone"));
107111
LocalDate localDate = LocalDate.of(2011, 12, 30);
108112
try (SqlSession sqlSession = sqlSessionFactory.openSession()) {
109113
Mapper mapper = sqlSession.getMapper(Mapper.class);

0 commit comments

Comments
 (0)