Test removing parameterType with generated keys

Author: emacarron

src/test/java/org/apache/ibatis/submitted/awful_table/AwfulTableMapper.xml

@@ -50,7 +50,7 @@
     delete from "awful table"
     where "CuStOmEr iD" = #{customerId,jdbcType=INTEGER}
   </delete>
-  <insert id="insert" parameterType="org.apache.ibatis.submitted.awful_table.AwfulTable" useGeneratedKeys="true" keyProperty="customerId" >
+  <insert id="insert" useGeneratedKeys="true" keyProperty="customerId" >
     insert into "awful table" ("first name", FIRST_NAME, 
       FIRSTNAME, "last name", E_MAIL, 
       "_id1", "$id2", "id5_", "id6$", 
@@ -62,7 +62,7 @@
       #{id7,jdbcType=INTEGER}, #{emailaddress,jdbcType=VARCHAR}, #{from,jdbcType=VARCHAR}, 
       #{active,jdbcType=BIT})
   </insert>
-  <insert id="insertSelective" parameterType="org.apache.ibatis.submitted.awful_table.AwfulTable" useGeneratedKeys="true" keyProperty="customerId" >
+  <insert id="insertSelective" useGeneratedKeys="true" keyProperty="customerId" >
     insert into "awful table"
     <trim prefix="(" suffix=")" suffixOverrides="," >
       <if test="firstFirstName != null" >

src/test/java/org/apache/ibatis/submitted/awful_table/AwfulTableTest.java

@@ -30,76 +30,67 @@
 import org.junit.Test;
 
 public class AwfulTableTest {
-    protected SqlSessionFactory sqlSessionFactory;
+  protected SqlSessionFactory sqlSessionFactory;
 
-    @Before
-    public void setUp() throws Exception {
-        Class.forName("org.hsqldb.jdbcDriver");
-        Connection conn = DriverManager.getConnection("jdbc:hsqldb:mem:attest",
-                "sa", "");
+  @Before
+  public void setUp() throws Exception {
+    Class.forName("org.hsqldb.jdbcDriver");
+    Connection conn = DriverManager.getConnection("jdbc:hsqldb:mem:attest", "sa", "");
 
-        Reader reader = Resources
-                .getResourceAsReader("org/apache/ibatis/submitted/awful_table/CreateDB.sql");
+    Reader reader = Resources.getResourceAsReader("org/apache/ibatis/submitted/awful_table/CreateDB.sql");
 
-        ScriptRunner runner = new ScriptRunner(conn);
-        runner.setLogWriter(null);
-        runner.setErrorLogWriter(null);
-        runner.runScript(reader);
-        conn.commit();
-        reader.close();
+    ScriptRunner runner = new ScriptRunner(conn);
+    runner.setLogWriter(null);
+    runner.setErrorLogWriter(null);
+    runner.runScript(reader);
+    conn.commit();
+    reader.close();
 
-        reader = Resources
-                .getResourceAsReader("org/apache/ibatis/submitted/awful_table/MapperConfig.xml");
-        sqlSessionFactory = new SqlSessionFactoryBuilder().build(reader);
-        reader.close();
-    }
+    reader = Resources.getResourceAsReader("org/apache/ibatis/submitted/awful_table/MapperConfig.xml");
+    sqlSessionFactory = new SqlSessionFactoryBuilder().build(reader);
+    reader.close();
+  }
 
-    @Test
-    public void testAwfulTableInsert() {
-        SqlSession sqlSession = sqlSessionFactory.openSession();
+  @Test
+  public void testAwfulTableInsert() {
+    SqlSession sqlSession = sqlSessionFactory.openSession();
 
-        try {
-            AwfulTableMapper mapper = sqlSession
-                    .getMapper(AwfulTableMapper.class);
-            AwfulTable record = new AwfulTable();
-            record.seteMail("[email protected]");
-            record.setEmailaddress("[email protected]");
-            record.setFirstFirstName("fred1");
-            record.setFrom("from field");
-            record.setId1(1);
-            record.setId2(2);
-            record.setId5(5);
-            record.setId6(6);
-            record.setId7(7);
-            record.setSecondFirstName("fred2");
-            record.setThirdFirstName("fred3");
+    try {
+      AwfulTableMapper mapper = sqlSession.getMapper(AwfulTableMapper.class);
+      AwfulTable record = new AwfulTable();
+      record.seteMail("[email protected]");
+      record.setEmailaddress("[email protected]");
+      record.setFirstFirstName("fred1");
+      record.setFrom("from field");
+      record.setId1(1);
+      record.setId2(2);
+      record.setId5(5);
+      record.setId6(6);
+      record.setId7(7);
+      record.setSecondFirstName("fred2");
+      record.setThirdFirstName("fred3");
 
-            mapper.insert(record);
-            Integer generatedCustomerId = record.getCustomerId();
-            assertEquals(57, generatedCustomerId.intValue());
+      mapper.insert(record);
+      Integer generatedCustomerId = record.getCustomerId();
+      assertEquals(57, generatedCustomerId.intValue());
 
-            AwfulTable returnedRecord = mapper
-                    .selectByPrimaryKey(generatedCustomerId);
+      AwfulTable returnedRecord = mapper.selectByPrimaryKey(generatedCustomerId);
 
-            assertEquals(generatedCustomerId, returnedRecord.getCustomerId());
-            assertEquals(record.geteMail(), returnedRecord.geteMail());
-            assertEquals(record.getEmailaddress(),
-                    returnedRecord.getEmailaddress());
-            assertEquals(record.getFirstFirstName(),
-                    returnedRecord.getFirstFirstName());
-            assertEquals(record.getFrom(), returnedRecord.getFrom());
-            assertEquals(record.getId1(), returnedRecord.getId1());
-            assertEquals(record.getId2(), returnedRecord.getId2());
-            assertEquals(record.getId5(), returnedRecord.getId5());
-            assertEquals(record.getId6(), returnedRecord.getId6());
-            assertEquals(record.getId7(), returnedRecord.getId7());
-            assertEquals(record.getSecondFirstName(),
-                    returnedRecord.getSecondFirstName());
-            assertEquals(record.getThirdFirstName(),
-                    returnedRecord.getThirdFirstName());
-        } finally {
-            sqlSession.close();
-        }
+      assertEquals(generatedCustomerId, returnedRecord.getCustomerId());
+      assertEquals(record.geteMail(), returnedRecord.geteMail());
+      assertEquals(record.getEmailaddress(), returnedRecord.getEmailaddress());
+      assertEquals(record.getFirstFirstName(), returnedRecord.getFirstFirstName());
+      assertEquals(record.getFrom(), returnedRecord.getFrom());
+      assertEquals(record.getId1(), returnedRecord.getId1());
+      assertEquals(record.getId2(), returnedRecord.getId2());
+      assertEquals(record.getId5(), returnedRecord.getId5());
+      assertEquals(record.getId6(), returnedRecord.getId6());
+      assertEquals(record.getId7(), returnedRecord.getId7());
+      assertEquals(record.getSecondFirstName(), returnedRecord.getSecondFirstName());
+      assertEquals(record.getThirdFirstName(), returnedRecord.getThirdFirstName());
+    } finally {
+      sqlSession.close();
     }
+  }
 
 }