Skip to content

Commit a4809f6

Browse files
committed
Tidy up
- Re-formatted. - Removed a few redundancies.
1 parent 0ca4860 commit a4809f6

File tree

1 file changed

+38
-42
lines changed

1 file changed

+38
-42
lines changed

src/main/java/org/apache/ibatis/parsing/XNode.java

Lines changed: 38 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -316,52 +316,48 @@ public Properties getChildrenAsProperties() {
316316
@Override
317317
public String toString() {
318318
StringBuilder builder = new StringBuilder();
319-
this.toString(builder, 0);
320-
return builder.toString();
319+
toString(builder, 0);
320+
return builder.toString();
321321
}
322-
322+
323323
private void toString(StringBuilder builder, int level) {
324-
builder.append("<");
325-
builder.append(name);
326-
for (Map.Entry<Object, Object> entry : attributes.entrySet()) {
327-
builder.append(" ");
328-
builder.append(entry.getKey());
329-
builder.append("=\"");
330-
builder.append(entry.getValue());
331-
builder.append("\"");
332-
}
333-
List<XNode> children = getChildren();
334-
if (!children.isEmpty()) {
335-
level++;
336-
builder.append(">\n");
337-
for (int k = 0; k < children.size(); k++) {
338-
this.applySpace(builder, level);
339-
children.get(k).toString(builder, level);
340-
}
341-
level--;
342-
this.applySpace(builder, level);
343-
builder.append("</");
344-
builder.append(name);
345-
builder.append(">");
346-
} else if (body != null) {
347-
builder.append(">");
348-
builder.append(body);
349-
builder.append("</");
350-
builder.append(name);
351-
builder.append(">");
352-
} else {
353-
builder.append("/>");
354-
this.applySpace(builder, level);
324+
builder.append("<");
325+
builder.append(name);
326+
for (Map.Entry<Object, Object> entry : attributes.entrySet()) {
327+
builder.append(" ");
328+
builder.append(entry.getKey());
329+
builder.append("=\"");
330+
builder.append(entry.getValue());
331+
builder.append("\"");
332+
}
333+
List<XNode> children = getChildren();
334+
if (!children.isEmpty()) {
335+
builder.append(">\n");
336+
for (int k = 0; k < children.size(); k++) {
337+
indent(builder, level + 1);
338+
children.get(k).toString(builder, level + 1);
355339
}
356-
builder.append("\n");
340+
indent(builder, level);
341+
builder.append("</");
342+
builder.append(name);
343+
builder.append(">");
344+
} else if (body != null) {
345+
builder.append(">");
346+
builder.append(body);
347+
builder.append("</");
348+
builder.append(name);
349+
builder.append(">");
350+
} else {
351+
builder.append("/>");
352+
indent(builder, level);
353+
}
354+
builder.append("\n");
357355
}
358-
359-
private StringBuilder applySpace(StringBuilder builder, int level) {
360-
for (int i=0; i<level; i++) {
361-
// append 4 space, each level retract 4 space base it's parent.
362-
builder.append(" ");
363-
}
364-
return builder;
356+
357+
private void indent(StringBuilder builder, int level) {
358+
for (int i = 0; i < level; i++) {
359+
builder.append(" ");
360+
}
365361
}
366362

367363
private Properties parseAttributes(Node n) {

0 commit comments

Comments
 (0)