Skip to content

Commit a943a1b

Browse files
authored
Merge pull request #3277 from mawen12/feature-transaction-test
Add TransactionFactory, Transaction test cases
2 parents 266542a + dcca250 commit a943a1b

24 files changed

+884
-28
lines changed

src/test/java/org/apache/ibatis/reflection/wrapper/BeanWrapperUnitTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
*
3737
* @see BeanWrapper
3838
*/
39-
class BeanWrapperUnitTest extends ObjectWrapperBaseTest {
39+
class BeanWrapperUnitTest extends ObjectWrapperBase {
4040

4141
private RichType richType;
4242

src/test/java/org/apache/ibatis/reflection/wrapper/CollectionWrapperUnitTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
* @see CollectionWrapper
3939
*/
4040
@ExtendWith(MockitoExtension.class)
41-
class CollectionWrapperUnitTest extends ObjectWrapperBaseTest {
41+
class CollectionWrapperUnitTest extends ObjectWrapperBase {
4242

4343
@Mock
4444
private Collection<Object> collection;

src/test/java/org/apache/ibatis/reflection/wrapper/MapWrapperUnitTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
*
4242
* @see MapWrapper
4343
*/
44-
class MapWrapperUnitTest extends ObjectWrapperBaseTest {
44+
class MapWrapperUnitTest extends ObjectWrapperBase {
4545

4646
@Mock
4747
private Map<String, Object> map;

src/test/java/org/apache/ibatis/reflection/wrapper/ObjectWrapperBaseTest.java renamed to src/test/java/org/apache/ibatis/reflection/wrapper/ObjectWrapperBase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
* @see ObjectWrapper
2525
*/
2626
@ExtendWith(MockitoExtension.class)
27-
abstract class ObjectWrapperBaseTest {
27+
abstract class ObjectWrapperBase {
2828

2929
abstract void shouldGet();
3030

src/test/java/org/apache/ibatis/scripting/xmltags/ChooseSqlNodeTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@
1515
*/
1616
package org.apache.ibatis.scripting.xmltags;
1717

18-
import static org.junit.jupiter.api.Assertions.assertTrue;
19-
import static org.mockito.Mockito.verify;
20-
import static org.mockito.Mockito.when;
21-
2218
import java.util.Arrays;
2319
import java.util.HashMap;
2420
import java.util.List;
@@ -27,6 +23,11 @@
2723
import org.junit.jupiter.api.BeforeEach;
2824
import org.junit.jupiter.api.Test;
2925

26+
import static org.junit.jupiter.api.Assertions.assertTrue;
27+
import static org.mockito.Mockito.verify;
28+
import static org.mockito.Mockito.when;
29+
30+
3031
/**
3132
* <pre>{@code
3233
* SELECT *
@@ -46,10 +47,9 @@
4647
* }</pre>
4748
*
4849
* @author <a href="[email protected]">mawen12</a>
49-
*
5050
* @see <a href="https://mybatis.org/mybatis-3/dynamic-sql.html#choose-when-otherwise">choose</a>
5151
*/
52-
class ChooseSqlNodeTest extends SqlNodeTest {
52+
class ChooseSqlNodeTest extends SqlNodeBase {
5353

5454
private static final String FIRST_TEXT = " AND title like #{title}";
5555
private static final String SECOND_TEXT = " AND author_name like #{author.username}";

src/test/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNodeTest.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@
1515
*/
1616
package org.apache.ibatis.scripting.xmltags;
1717

18-
import static org.junit.jupiter.api.Assertions.assertEquals;
19-
import static org.junit.jupiter.api.Assertions.assertTrue;
20-
import static org.mockito.Mockito.*;
21-
2218
import java.util.Arrays;
2319
import java.util.HashMap;
2420
import java.util.List;
@@ -27,6 +23,13 @@
2723
import org.junit.jupiter.api.Test;
2824
import org.mockito.ArgumentCaptor;
2925

26+
import static org.junit.jupiter.api.Assertions.assertEquals;
27+
import static org.junit.jupiter.api.Assertions.assertTrue;
28+
import static org.mockito.Mockito.doNothing;
29+
import static org.mockito.Mockito.when;
30+
import static org.mockito.Mockito.verify;
31+
32+
3033
/**
3134
* <pre>{@code
3235
* SELECT *
@@ -39,10 +42,9 @@
3942
* }</pre>
4043
*
4144
* @author <a href="[email protected]">mawen12</a>
42-
*
4345
* @see <a href="https://mybatis.org/mybatis-3/dynamic-sql.html#foreach">foreach</a>
4446
*/
45-
class ForEachSqlNodeTest extends SqlNodeTest {
47+
class ForEachSqlNodeTest extends SqlNodeBase {
4648

4749
private SqlNode sqlNode;
4850

src/test/java/org/apache/ibatis/scripting/xmltags/IfSqlNodeTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@
1717

1818
import static org.junit.jupiter.api.Assertions.assertFalse;
1919
import static org.junit.jupiter.api.Assertions.assertTrue;
20-
import static org.mockito.Mockito.*;
20+
import static org.mockito.Mockito.verify;
21+
import static org.mockito.Mockito.when;
22+
import static org.mockito.Mockito.never;
2123

2224
import java.util.HashMap;
2325

@@ -35,7 +37,7 @@
3537
*
3638
* @see <a href="https://mybatis.org/mybatis-3/dynamic-sql.html#if">if</a>
3739
*/
38-
class IfSqlNodeTest extends SqlNodeTest {
40+
class IfSqlNodeTest extends SqlNodeBase {
3941

4042
private static final String CONDITION = "title != null";
4143
private static final String TEXT = "AND title like #{title}";

src/test/java/org/apache/ibatis/scripting/xmltags/MixedSqlNodeTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,18 @@
1515
*/
1616
package org.apache.ibatis.scripting.xmltags;
1717

18-
import static org.mockito.Mockito.verify;
19-
2018
import java.util.Arrays;
2119

2220
import org.junit.jupiter.api.BeforeEach;
2321
import org.junit.jupiter.api.Test;
2422

23+
import static org.mockito.Mockito.verify;
24+
25+
2526
/**
2627
* @author <a href="[email protected]">mawen12</a>
2728
*/
28-
class MixedSqlNodeTest extends SqlNodeTest {
29+
class MixedSqlNodeTest extends SqlNodeBase {
2930

3031
private static final String FIRST_TEXT = "abc";
3132
private static final String SECOND_TEXT = "bcd";

src/test/java/org/apache/ibatis/scripting/xmltags/SetSqlNodeTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
*
4444
* @see <a href="https://mybatis.org/mybatis-3/dynamic-sql.html#trim-where-set">trim-where-set</a>
4545
*/
46-
class SetSqlNodeTest extends SqlNodeTest {
46+
class SetSqlNodeTest extends SqlNodeBase {
4747

4848
private static final String FIRST_TEXT = " username = #{username},";
4949
private static final String SECOND_TEXT = " password = #{password}";

src/test/java/org/apache/ibatis/scripting/xmltags/SqlNodeTest.java renamed to src/test/java/org/apache/ibatis/scripting/xmltags/SqlNodeBase.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,10 @@
2222

2323
/**
2424
* @author <a href="[email protected]">mawen12</a>
25+
* @see SqlNode
2526
*/
2627
@ExtendWith(MockitoExtension.class)
27-
abstract class SqlNodeTest {
28+
abstract class SqlNodeBase {
2829

2930
@Mock
3031
protected Configuration configuration;

0 commit comments

Comments
 (0)