Skip to content

Commit aa38fec

Browse files
committed
[ci] Add final where appropriate per open rewrite
relaxed some of its suggestions but generally took most.
1 parent 105914b commit aa38fec

File tree

42 files changed

+82
-82
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+82
-82
lines changed

src/main/java/org/apache/ibatis/datasource/unpooled/UnpooledDataSource.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public class UnpooledDataSource implements DataSource {
4040

4141
private ClassLoader driverClassLoader;
4242
private Properties driverProperties;
43-
private static Map<String, Driver> registeredDrivers = new ConcurrentHashMap<>();
43+
private static final Map<String, Driver> registeredDrivers = new ConcurrentHashMap<>();
4444

4545
private String driver;
4646
private String url;
@@ -263,7 +263,7 @@ private void configureConnection(Connection conn) throws SQLException {
263263
}
264264

265265
private static class DriverProxy implements Driver {
266-
private Driver driver;
266+
private final Driver driver;
267267

268268
DriverProxy(Driver d) {
269269
this.driver = d;

src/main/java/org/apache/ibatis/executor/loader/ResultLoaderMap.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ public static class LoadPair implements Serializable {
134134
/**
135135
* Name of the unread property.
136136
*/
137-
private String property;
137+
private final String property;
138138
/**
139139
* ID of SQL statement which loads the property.
140140
*/

src/main/java/org/apache/ibatis/io/ResolverUtil.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public interface Test {
8787
public static class IsA implements Test {
8888

8989
/** The parent. */
90-
private Class<?> parent;
90+
private final Class<?> parent;
9191

9292
/**
9393
* Constructs an IsA test using the supplied Class as the parent class/interface.
@@ -118,7 +118,7 @@ public String toString() {
118118
public static class AnnotatedWith implements Test {
119119

120120
/** The annotation. */
121-
private Class<? extends Annotation> annotation;
121+
private final Class<? extends Annotation> annotation;
122122

123123
/**
124124
* Constructs an AnnotatedWith test for the specified annotation type.

src/main/java/org/apache/ibatis/io/Resources.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
*/
3333
public class Resources {
3434

35-
private static ClassLoaderWrapper classLoaderWrapper = new ClassLoaderWrapper();
35+
private static final ClassLoaderWrapper classLoaderWrapper = new ClassLoaderWrapper();
3636

3737
/**
3838
* Charset to use when calling getResourceAsReader. null means use the system default.

src/main/java/org/apache/ibatis/mapping/Discriminator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public class Discriminator {
3232
}
3333

3434
public static class Builder {
35-
private Discriminator discriminator = new Discriminator();
35+
private final Discriminator discriminator = new Discriminator();
3636

3737
public Builder(Configuration configuration, ResultMapping resultMapping, Map<String, String> discriminatorMap) {
3838
discriminator.resultMapping = resultMapping;

src/main/java/org/apache/ibatis/mapping/MappedStatement.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public final class MappedStatement {
6363
}
6464

6565
public static class Builder {
66-
private MappedStatement mappedStatement = new MappedStatement();
66+
private final MappedStatement mappedStatement = new MappedStatement();
6767

6868
public Builder(Configuration configuration, String id, SqlSource sqlSource, SqlCommandType sqlCommandType) {
6969
mappedStatement.configuration = configuration;

src/main/java/org/apache/ibatis/mapping/ParameterMap.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ private ParameterMap() {
3333
}
3434

3535
public static class Builder {
36-
private ParameterMap parameterMap = new ParameterMap();
36+
private final ParameterMap parameterMap = new ParameterMap();
3737

3838
public Builder(Configuration configuration, String id, Class<?> type, List<ParameterMapping> parameterMappings) {
3939
parameterMap.id = id;

src/main/java/org/apache/ibatis/mapping/ParameterMapping.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ private ParameterMapping() {
4343
}
4444

4545
public static class Builder {
46-
private ParameterMapping parameterMapping = new ParameterMapping();
46+
private final ParameterMapping parameterMapping = new ParameterMapping();
4747

4848
public Builder(Configuration configuration, String property, TypeHandler<?> typeHandler) {
4949
parameterMapping.configuration = configuration;

src/main/java/org/apache/ibatis/mapping/ResultMap.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ private ResultMap() {
5656
public static class Builder {
5757
private static final Log log = LogFactory.getLog(Builder.class);
5858

59-
private ResultMap resultMap = new ResultMap();
59+
private final ResultMap resultMap = new ResultMap();
6060

6161
public Builder(Configuration configuration, String id, Class<?> type, List<ResultMapping> resultMappings) {
6262
this(configuration, id, type, resultMappings, null);

src/main/java/org/apache/ibatis/mapping/ResultMapping.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public class ResultMapping {
5050
}
5151

5252
public static class Builder {
53-
private ResultMapping resultMapping = new ResultMapping();
53+
private final ResultMapping resultMapping = new ResultMapping();
5454

5555
public Builder(Configuration configuration, String property, String column, TypeHandler<?> typeHandler) {
5656
this(configuration, property);

0 commit comments

Comments
 (0)