fixes #1146 A double value 0.0d should be evaluated as false. BigDecimal#equals() is too strict.

Author: harawata

src/main/java/org/apache/ibatis/scripting/xmltags/ExpressionEvaluator.java

@@ -34,7 +34,7 @@ public boolean evaluateBoolean(String expression, Object parameterObject) {
       return (Boolean) value;
     }
     if (value instanceof Number) {
-        return !new BigDecimal(String.valueOf(value)).equals(BigDecimal.ZERO);
+      return new BigDecimal(String.valueOf(value)).compareTo(BigDecimal.ZERO) != 0;
     }
     return value != null;
   }

src/test/java/org/apache/ibatis/builder/xml/dynamic/ExpressionEvaluatorTest.java

@@ -15,14 +15,13 @@
  */
 package org.apache.ibatis.builder.xml.dynamic;
 
+import static org.junit.Assert.*;
+
 import java.util.HashMap;
 
 import org.apache.ibatis.domain.blog.Author;
 import org.apache.ibatis.domain.blog.Section;
 import org.apache.ibatis.scripting.xmltags.ExpressionEvaluator;
-
-import static org.junit.Assert.assertEquals;
-
 import org.junit.Test;
 
 public class ExpressionEvaluatorTest {
@@ -65,6 +64,15 @@ public void shouldReturnFalseIfZero() {
     assertEquals(false, value);
   }
 
+  @Test
+  public void shouldReturnFalseIfZeroWithScale() {
+    class Bean {
+      @SuppressWarnings("unused")
+      public double d = 0.0d;
+    }
+    assertFalse(evaluator.evaluateBoolean("d", new Bean()));
+  }
+
   @Test
   public void shouldIterateOverIterable() {
     final HashMap<String, String[]> parameterObject = new HashMap<String, String[]>() {{