Skip to content

Commit bedac5a

Browse files
authored
Merge pull request #2992 from hazendaz/master
Build cleanup
2 parents ab67df3 + 92a3a2c commit bedac5a

File tree

3 files changed

+5
-14
lines changed

3 files changed

+5
-14
lines changed

.github/workflows/ci.yaml

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,27 +7,20 @@ jobs:
77
runs-on: ${{ matrix.os }}
88
strategy:
99
matrix:
10-
os: [ubuntu-latest, macOS-latest, windows-latest]
11-
java: [11, 17, 21, 22]
12-
distribution: ['zulu']
10+
os: [ubuntu-latest, macos-latest, windows-latest]
11+
java: [11, 17, 21, 22-ea]
12+
distribution: ['temurin']
1313
fail-fast: false
1414
max-parallel: 4
1515
name: Test JDK ${{ matrix.java }}, ${{ matrix.os }}
1616

1717
steps:
1818
- uses: actions/checkout@v4
19-
- name: Set JDK from jdk.java.net
20-
uses: oracle-actions/setup-java@v1
21-
with:
22-
website: jdk.java.net
23-
release: ${{ matrix.java }}
24-
if: ${{ matrix.java != '11' && matrix.java != '17' }}
25-
- name: Set up older JDK
19+
- name: Set up JDK
2620
uses: actions/setup-java@v3
2721
with:
2822
java-version: ${{ matrix.java }}
2923
distribution: ${{ matrix.distribution }}
30-
if: ${{ matrix.java == '11' || matrix.java == '17' }}
3124
- name: Print JDK Version
3225
run: java -version
3326
- name: Cache local Maven m2

pom.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,6 @@
154154

155155
<!-- Reproducible Builds -->
156156
<project.build.outputTimestamp>1698763635</project.build.outputTimestamp>
157-
158-
<allowed.build.jdks>[11,12),[17,18),[21,22),[22,23)</allowed.build.jdks>
159157
</properties>
160158

161159
<dependencies>

src/main/java/org/apache/ibatis/jdbc/ScriptRunner.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ private void executeStatement(String command) throws SQLException {
248248
}
249249
try {
250250
boolean hasResults = statement.execute(sql);
251-
// DO NOT try to 'imporove' the condition even if IDE tells you to!
251+
// DO NOT try to 'improve' the condition even if IDE tells you to!
252252
// It's important that getUpdateCount() is called here.
253253
while (!(!hasResults && statement.getUpdateCount() == -1)) {
254254
checkWarnings(statement);

0 commit comments

Comments
 (0)