Skip to content

Commit c6e054d

Browse files
committed
fix review
1 parent 5ffa356 commit c6e054d

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

src/main/java/org/apache/ibatis/datasource/unpooled/UnpooledDataSource.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,6 @@ public boolean jdbcCompliant() {
292292
return this.driver.jdbcCompliant();
293293
}
294294

295-
// @Override only valid jdk7+
296295
@Override
297296
public Logger getParentLogger() {
298297
return Logger.getLogger(Logger.GLOBAL_LOGGER_NAME);
@@ -309,7 +308,6 @@ public boolean isWrapperFor(Class<?> iface) throws SQLException {
309308
return false;
310309
}
311310

312-
// @Override only valid jdk7+
313311
@Override
314312
public Logger getParentLogger() {
315313
// requires JDK version 1.6

src/main/java/org/apache/ibatis/mapping/SqlCommandType.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@
1919
* @author Clinton Begin
2020
*/
2121
public enum SqlCommandType {
22-
UNKNOWN, INSERT, UPDATE, DELETE, SELECT, FLUSH
22+
UNKNOWN, INSERT, UPDATE, DELETE, SELECT, FLUSH;
2323
}

src/test/java/org/apache/ibatis/autoconstructor/ExtensiveSubject.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,6 @@ public ExtensiveSubject(final byte aByte,
6262
}
6363

6464
public enum TestEnum {
65-
AVALUE, BVALUE, CVALUE
65+
AVALUE, BVALUE, CVALUE;
6666
}
6767
}

src/test/java/org/apache/ibatis/session/SqlSessionTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -583,7 +583,7 @@ void shouldFailSelectOneAuthorUsingMapperClassWithTwoResultHandlers() {
583583
Configuration configuration = new Configuration(sqlMapper.getConfiguration().getEnvironment());
584584
configuration.addMapper(AuthorMapperWithMultipleHandlers.class);
585585
SqlSessionFactory sqlMapperWithMultipleHandlers = new DefaultSqlSessionFactory(configuration);
586-
try (SqlSession sqlSession = sqlMapperWithMultipleHandlers.openSession()) {
586+
try (SqlSession sqlSession = sqlMapperWithMultipleHandlers.openSession();) {
587587
DefaultResultHandler handler1 = new DefaultResultHandler();
588588
DefaultResultHandler handler2 = new DefaultResultHandler();
589589
AuthorMapperWithMultipleHandlers mapper = sqlSession.getMapper(AuthorMapperWithMultipleHandlers.class);
@@ -596,7 +596,7 @@ void shouldFailSelectOneAuthorUsingMapperClassWithTwoRowBounds() {
596596
Configuration configuration = new Configuration(sqlMapper.getConfiguration().getEnvironment());
597597
configuration.addMapper(AuthorMapperWithRowBounds.class);
598598
SqlSessionFactory sqlMapperWithMultipleHandlers = new DefaultSqlSessionFactory(configuration);
599-
try (SqlSession sqlSession = sqlMapperWithMultipleHandlers.openSession()) {
599+
try (SqlSession sqlSession = sqlMapperWithMultipleHandlers.openSession();) {
600600
RowBounds bounds1 = new RowBounds(0, 1);
601601
RowBounds bounds2 = new RowBounds(0, 1);
602602
AuthorMapperWithRowBounds mapper = sqlSession.getMapper(AuthorMapperWithRowBounds.class);

0 commit comments

Comments
 (0)