Fix for http://code.google.com/p/mybatis/issues/detail?id=209

Author: jeffgbutler

src/main/java/org/apache/ibatis/builder/xml/dynamic/ExpressionEvaluator.java

@@ -5,8 +5,10 @@
 import org.apache.ibatis.ognl.Ognl;
 import org.apache.ibatis.ognl.OgnlException;
 
+import java.lang.reflect.Array;
 import java.math.BigDecimal;
-import java.util.Arrays;
+import java.util.ArrayList;
+import java.util.List;
 
 public class ExpressionEvaluator {
 
@@ -21,12 +23,24 @@ public boolean evaluateBoolean(String expression, Object parameterObject) {
     }
   }
 
-  public Iterable evaluateIterable(String expression, Object parameterObject) {
+  public Iterable<?> evaluateIterable(String expression, Object parameterObject) {
     try {
       Object value = Ognl.getValue(expression, parameterObject);
       if (value == null) throw new SqlMapperException("The expression '" + expression + "' evaluated to a null value.");
-      if (value instanceof Iterable) return (Iterable) value;
-      if (value.getClass().isArray()) return Arrays.asList((Object[]) value);
+      if (value instanceof Iterable) return (Iterable<?>) value;
+      if (value.getClass().isArray()) {
+          // the array may be primitive, so Arrays.asList() may throw 
+          // a ClassCastException (issue 209).  Do the work manually
+          // Curse primitives! :) (JGB)
+          int size = Array.getLength(value);
+          List<Object> answer = new ArrayList<Object>();
+          for (int i = 0; i < size; i++) {
+              Object o = Array.get(value, i);
+              answer.add(o);
+          }
+          
+          return answer;
+      }
       throw new BuilderException("Error evaluating expression '" + expression + "'.  Return value (" + value + ") was not iterable.");
     } catch (OgnlException e) {
       throw new BuilderException("Error evaluating expression '" + expression + "'. Cause: " + e, e);

src/test/java/org/apache/ibatis/submitted/nested/NestedForEach.xml

@@ -26,4 +26,14 @@
       </foreach>
     </where>
   </select>
+
+  <select id="simpleSelectWithPrimitives" parameterType="map" resultType="map">
+    select *
+    from names
+    <where>
+      <foreach collection="ids" item="id" separator="," open="id in (" close=")">
+        ${id}
+      </foreach>
+    </where>
+  </select>
 </mapper>

src/test/java/org/apache/ibatis/submitted/nested/NestedForEachTest.java

@@ -13,6 +13,7 @@
 import java.io.Reader;
 import java.sql.Connection;
 import java.sql.DriverManager;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
@@ -67,6 +68,24 @@ public void testSimpleSelect() {
     }
   }
 
+  @Test
+  @SuppressWarnings("unchecked")
+  public void testSimpleSelectWithPrimitives() {
+    SqlSession sqlSession = sqlSessionFactory.openSession();
+    try {
+      Map<String, Object> parameter = new HashMap<String, Object>();
+      int[] array = new int[] {1, 3, 5};
+      parameter.put("ids", array);
+
+      List<Map<String, Object>> answer =
+          sqlSession.selectList("org.apache.ibatis.submitted.nested.simpleSelectWithPrimitives", parameter);
+
+      assertEquals(3, answer.size());
+    } finally {
+      sqlSession.close();
+    }
+  }
+  
   @Test
   @SuppressWarnings("unchecked")
   public void testNestedSelect() {