Skip to content

Commit d6ef7ec

Browse files
committed
Implemented factory methods, made constructor private.
1 parent 5766c7a commit d6ef7ec

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

src/main/java/org/apache/ibatis/session/SqlSessionManager.java

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,20 @@ public class SqlSessionManager implements SqlSessionFactory, SqlSession {
1515

1616
private ThreadLocal<SqlSession> localSqlSession = new ThreadLocal<SqlSession>();
1717

18-
public SqlSessionManager(Reader reader) {
19-
this(new SqlSessionFactoryBuilder().build(reader, null, null));
18+
private SqlSessionManager(Reader reader, Properties properties) {
19+
this(new SqlSessionFactoryBuilder().build(reader, null, properties));
2020
}
2121

22-
public SqlSessionManager(Reader reader, String environment) {
23-
this(new SqlSessionFactoryBuilder().build(reader, environment, null));
22+
public static SqlSessionManager newInstance(Reader reader) {
23+
return new SqlSessionManager(new SqlSessionFactoryBuilder().build(reader, null, null));
2424
}
2525

26-
public SqlSessionManager(Reader reader, Properties properties) {
27-
this(new SqlSessionFactoryBuilder().build(reader, null, properties));
26+
public static SqlSessionManager newInstance(Reader reader, String environment) {
27+
return new SqlSessionManager(new SqlSessionFactoryBuilder().build(reader, environment, null));
28+
}
29+
30+
public static SqlSessionManager newInstance(Reader reader, Properties properties) {
31+
return new SqlSessionManager(new SqlSessionFactoryBuilder().build(reader, null, properties));
2832
}
2933

3034
public SqlSessionManager(SqlSessionFactory sqlSessionFactory) {

0 commit comments

Comments
 (0)